Summary | False positive SMIME verification |
Queue | Horde Framework Packages |
Queue Version | FRAMEWORK_3 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | Horde Developers (at) , selsky (at) columbia (dot) edu |
Requester | thomas.belot (at) atosorigin (dot) com |
Created | 02/26/2008 (6348 days ago) |
Due | |
Updated | 03/14/2008 (6331 days ago) |
Assigned | 03/13/2008 (6332 days ago) |
Resolved | 03/14/2008 (6331 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 3.2 |
Patch | No |
Assigned to Matt Selsky
State ⇒ Resolved
New Attachment: smime.patch
testing? How did you break the message to get openssl_pkcs7_verify()
to return -1?
and false which means an invalid cert.
cases (output is not filled).
If you want to raise two different messages, we need to contact PHP's
openssl team and ask for a third return code
State ⇒ Assigned
Assigned to
Milestone ⇒ 3.2
I wrote the signature function that caused invalid signature
production and I had two problem : Invalid signature syntax AND
invalid signature
When facing both problems the function returs -1 as the invalid
signature is unparsable ... but still invalid
State ⇒ Feedback
Priority ⇒ 2. Medium
false. The commit message that allowed -1 as a valid return, says:
"openssl_pkcs7_verify returns -1 when the signature is ok but there
are no certificates to return."
Priority ⇒ 3. High
State ⇒ Unconfirmed
Queue ⇒ Horde Framework Packages
Summary ⇒ False positive SMIME verification
Type ⇒ Bug
212:/* Try again without verfying the signer's cert */
213: $result = openssl_pkcs7_verify($input, PKCS7_NOVERIFY, $output);
214:
215: if (($result === true) || ($result === -1)) {
216: [Verification OK]
217: } else {
218: [Verification KO]
219: }
Verification is OK if "$result === -1" but "openssl_pkcs7_verify"
documentation specify that "[openssl_pkcs7_verify] Returns [...] -1 on
error."
Why do you consider -1 a valid verification ???
In my case, I had malformed smime signature which lead to an
encouraging message "valid message verification, but unknown issuer"...