| Summary | Support for Date_Holidays filter |
| Queue | Kronolith |
| Queue Version | HEAD |
| Type | Enhancement |
| State | Stalled |
| Priority | 1. Low |
| Owners | |
| Requester | hordelist (at) quantentunnel (dot) de |
| Created | 02/20/2008 (81 days ago) |
| Due | |
| Updated | 04/27/2008 (14 days ago) |
| Assigned | |
| Resolved | 04/23/2008 (18 days ago) |
| Attachments | |
| Milestone | |
| Patch |
Great, thanks for keeping us updated.Just to bring you up to date: As it seems, filters have been anything but abandoned. Only a certain method of specifying filters has been dropped (the PHPdocs were a bit confusing about that).
I am currently trying to convince the DH guys to provide a factory method for filters.
Once that is released, I should be able to provide a patch for filter support in no-time.
State ⇒ Stalled
Stalling while Date_Holidays figures this out.If it's realy depricated then it's useless to support. Havn't seen this, only that there are additional filters to get only the official holidays. Right now at least the german driver is useless for office. Only holidays without work are needed, so nobody makes appointments by mistake. No need for Girl's Day, BeerDay, WordLaughingDay and so on. They confuse and mess up the calendar.
As already noted, some holidays are different by state in germany. So having filters looks like a good solution - how should they be replaced? Creating a new driver, so there are at least 16 for germany?
Guess we have to figure out how the Date_Holiday project intends to solve this and if filters are realy droped. I hope you get an answer from Carsten.
Hello,
I am the one who wrote the initial patch to enable kronolith drawing out holidays from Date_Holidays. When I wrote that patch I was under the impression that filters were an abandoned concept, which was the reason my patch didn't feature support for filters.
I just had a look at this and found that all entry points for specifying filters were marked as 'deprecated'. Yet there seems to have been some activity regarding filters during the last two weeks. I'll try to contact Carsten Lucke, who is the head developer of this package, about this to get a final word on this feature.
Anyway, assuming filters have not been discontinued, it is still going to take a while for this to work, as invoking filters is a bit more complicated than working with drivers alone. E.g. there is no factory method for them and the composite filter demands filter objects, so I cannot just feed it some filter's names from the preference system.
Queue ⇒ Kronolith
Summary ⇒ Support for Date_Holidays filter
Type ⇒ Enhancement
Priority ⇒ 1. Low
State ⇒ New
Add support for different Date_Holidays_Filter_*
PEAR DATE_Holidays supports whitelist filter for holidays, right now there are filters for official holidays, like Date_Holidays_Filter_Germany_Official, Date_Holidays_Filter_Netherlands_Official but also for the different holidays in the german states like Date_Holidays_Filter_Germany_NorthRhineWestphalia, Date_Holidays_Filter_Germany_Bavaria but also others.