6.0.0-alpha12
6/18/25

[#6172] Bad Month links in year view
Summary Bad Month links in year view
Queue Kronolith
Queue Version 2.1.6
Type Bug
State Resolved
Priority 2. Medium
Owners chuck (at) horde (dot) org
Requester hofsteda (at) gmail (dot) com
Created 01/29/2008 (6350 days ago)
Due
Updated 01/29/2008 (6350 days ago)
Assigned
Resolved 01/29/2008 (6350 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
01/29/2008 10:51:24 PM Chuck Hagenbuch Comment #2
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
That timestamp does seem completely unnecessary. Fixed in CVS, merging 
to FW_3. Thanks!
01/29/2008 07:27:39 PM hofsteda (at) gmail (dot) com Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Bad Month links in year view
Queue ⇒ Kronolith
Reply to this comment
Clicking on month's link where the 1st falls on the first day of the 
week (Sunday/Monday according to prefs) in the year view brings up the 
previous month's month view due to the timestamp in the month's url 
generated by year.php e.g. 9/08 with Monday as start of week. 6/08 
w/Sunday as start of week.  The timestamp used in the month's url is 
generated in for next loop used for the previous months events.  If 
the last day of the week (Saturday/Sunday) is the last day of the 
month this timestamp is in the previous month.



Two fixes I see:

1. remove the timestamp in the $url = on line ~74. It doesn't seem necessary.

2. add 1 to daysinview if endday=HORDE_DATE_SATURDAY/HORDE_DATE_SUNDAY 
in the ifs used to generate $startofview $daysofview. This may cause 
issues with previous months.

Saved Queries