Summary | Bad Month links in year view |
Queue | Kronolith |
Queue Version | 2.1.6 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | chuck (at) horde (dot) org |
Requester | hofsteda (at) gmail (dot) com |
Created | 01/29/2008 (6350 days ago) |
Due | |
Updated | 01/29/2008 (6350 days ago) |
Assigned | |
Resolved | 01/29/2008 (6350 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Assigned to Chuck Hagenbuch
State ⇒ Resolved
to FW_3. Thanks!
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Bad Month links in year view
Queue ⇒ Kronolith
week (Sunday/Monday according to prefs) in the year view brings up the
previous month's month view due to the timestamp in the month's url
generated by year.php e.g. 9/08 with Monday as start of week. 6/08
w/Sunday as start of week. The timestamp used in the month's url is
generated in for next loop used for the previous months events. If
the last day of the week (Saturday/Sunday) is the last day of the
month this timestamp is in the previous month.
Two fixes I see:
1. remove the timestamp in the $url = on line ~74. It doesn't seem necessary.
2. add 1 to daysinview if endday=HORDE_DATE_SATURDAY/HORDE_DATE_SUNDAY
in the ifs used to generate $startofview $daysofview. This may cause
issues with previous months.