Fixed some additonal stuff and commited to CVS.

Guess I need to solve this earlier than I thought.



I looked through this again and it is probably not as hard as I assumed.



Current situation:



Patch 1:



Differentiate between folder type and object type within the folder

(http://hg.pardus.de/cgi-bin/hg.cgi/horde/HORDE_CVS/file/tip/framework/HK-GW-Split_object_folder_type.patch)



Patch2:



Disttribution list XML format

(http://hg.pardus.de/cgi-bin/hg.cgi/horde/HORDE_CVS/file/tip/framework/HK-MG-Distlists.patch)



Patch3:



Turba Kolab Driver distlist support

(http://hg.pardus.de/cgi-bin/hg.cgi/horde/HORDE_CVS/file/tip/turba/HK-MG-Distlists.patch)



Patch4:



Still broken parts of Turba distlist support

(http://hg.pardus.de/cgi-bin/hg.cgi/horde/HORDE_CVS/file/tip/turba/HK-MG-Distlists_broken.patch)



Patch1 is how I imagine the object/folder type split should look like.



Patch 2-4 originate from you.



Patch 4 holds the stuff that I still need to check and integrate into 
the Turba Kolab Driver. This is stuff I cant put into the Kolab module 
since the Kolab module should not know too much about the different 
applications. I imagine Turba should be well able to handle these 
parts itself using the new setFolderType($type) function in 
Kolab/IMAP.php.



So this is just an update that I'm working on this. Any feedback welcome.

Your comments indicate that you also noticed that you hacked the 
distribution list into the IMAP.php driver :) but I can't commit it 
that way. We need a more general solution there that allows different 
XML types in a folder.



I thought this would only need minor restructuring but in fact the 
_object_type problem needs some more work. I won't add that before we 
move to Horde 4.



So I'll keep your patch in the queue as I hope to start restructuring 
soon. You'll find my current version here: 
http://hg.pardus.de/cgi-bin/hg.cgi/horde/HORDE_CVS/file/tip/turba/HK-MG-Distlists.patch

A general note on patch submission:



Clean patches have a much higher chance of ending up in CVS. So if 
possible you should provide patches that do match exactly against CVS. 
Patch files in framework/* rather than in lib/Horde/*. Any conflicts 
in the patches makes it significantly harder to import the stuff.



Other than that: Thanks for providing this!



I imported this now into my patch queue and will work towards 
commiting it to CVS.

and add the XML driver horde-kolab-xml-distlist.php to



   horde/lib/Horde/Kolab/XML/



as



   distribution-list.php

here is the patch...

attached you find a draft that makes kolab's private distribution 
lists accessible in horde...



what is still missing (as it is a draft that people should look at 
before more work is done):



   o cross-storing contacts / distlist in different kolab address 
books (put contact A from

      address book A into distlist A in addressbook B)

   o create new contacts, if (by some reason, broken kolab clients, 
maybe) a contact is in a

     dist list, but cannot be mapped to any Turba_Object



WATCH OUT: the attached patch has been diffed against a 
horde-kolab-cvs site that's been patched with gunnar's kolab 
patches... so things might look slightly different as if it had been 
patched against a vanilla horde-cvs...



Have FUN with this!!!

Mike

Horde does not have support for Kolab's private distribution lists, yet.