Summary | subtasks loose parent task when finished |
Queue | Kolab |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | m.gabriel (at) das-netzwerkteam (dot) de |
Created | 12/24/2007 (6392 days ago) |
Due | |
Updated | 12/27/2007 (6389 days ago) |
Assigned | 12/26/2007 (6390 days ago) |
Resolved | 12/27/2007 (6389 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
Assigned to Jan Schneider
State ⇒ Assigned
not, and look at the patch?
Mike: may I gently point you at horde/docs/CODING_STANDARDS, and
http://www.horde.org/source/contribute.php, so you don't have to
wonder. :) Also, no need to paste inline patches that you're
uploading. Thanks!
New Attachment: task.php.patch
grimnir:/usr/local/share/_horde-versions_# diff -u
horde-webmail-1.1-rc1/nag/task.php
horde-webmail-1.1-rc1-netzwerkteam/nag/task.php
--- horde-webmail-1.1-rc1/nag/task.php 2007-11-29 12:32:56.000000000 +0000
+++ horde-webmail-1.1-rc1-netzwerkteam/nag/task.php 2007-12-26
17:19:41.000000000 +0000
@@ -210,7 +210,7 @@
$tasklist_id = Util::getFormData('tasklist');
if (isset($task_id)) {
$share = $GLOBALS['nag_shares']->getShare($tasklist_id);
- $task = new Nag_Task(Nag::getTask($tasklist_id, $task_id));
+ $task = Nag::getTask($tasklist_id, $task_id);
if (is_a($share, 'PEAR_Error') ||
!$share->hasPermission(Auth::getAuth(), PERMS_EDIT)) {
$notification->push(sprintf(_("Access denied completing
task %s."), $task->name), 'horde.error');
} else {
Queue ⇒ Kolab
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ subtasks loose parent task when finished
Queue ⇒ Nag
State ⇒ Unconfirmed
horde-webmail-edition-1.1-rc1.
when i finish a subtask in nag, it is removed from the parent task
list and turned into a top-level task.
example:
before:
[ ] Mail Server migration
[ ] Setup Horde
[ ] Setup mailman
after horde setup is complete:
[ ] Mail server migration
[ ] Setup mailman
[x] Setup Horde
to my point of view it should look like this after horde setup:
[ ] Mail server migration
[x] Setup Horde
[ ] Setup mailman
best,
mike