[#5716] Adding quick links for adding notes to notepads
Summary Adding quick links for adding notes to notepads
Queue Mnemo
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners Chuck Hagenbuch <chuck (at) horde (dot) org>
Requester Gunnar Wrobel <p (at) rdus (dot) de>
Created 09/11/2007 (243 days ago)
Due
Updated 09/14/2007 (240 days ago)
Assigned
Resolved 09/14/2007 (240 days ago)
Attachments mnemo_tree-menu-links_20070914.patch Download
Milestone
Patch

History
09/14/2007 Chuck Hagenbuch Comment #6
State ⇒ Resolved
Assigned to Chuck Hagenbuch		 Reply to this comment
Committed, thanks. I just changed the name of the link to be a bit shorter for space.
09/14/2007 Chuck Hagenbuch Deleted Attachment: mnemo_tree-menu-links_20070913.patch
 
09/14/2007 Gunnar Wrobel Comment #5
New Attachment: mnemo_tree-menu-links_20070914.patch Download		 Reply to this comment
> I'd prefer that the bit to only show the contents on a single notepad
> was separated from the quick add links; if you really want it and
> really want to keep it as part of this patch then I think you really
> have to provide some visual feedback to the user. And I'm not sure
> that directly overriding the $display_notepads global is the best way
> to achieve it.

No I'd rather split this then and open a new ticket for the single folder listing. Reduced patch attached. If you accept it like that I would patch the other apps (nag, kronolith, turba) in a similar fashion if it does not deviate too much from the patch suggested here.
09/14/2007 Chuck Hagenbuch Comment #4 Reply to this comment
I'd prefer that the bit to only show the contents on a single notepad was separated from the quick add links; if you really want it and really want to keep it as part of this patch then I think you really have to provide some visual feedback to the user. And I'm not sure that directly overriding the $display_notepads global is the best way to achieve it.
09/14/2007 Chuck Hagenbuch Deleted Attachment: mnemo_tree-menu-links_20070911.patch
 
09/13/2007 Gunnar Wrobel Comment #3
New Attachment: mnemo_tree-menu-links_20070913.patch		 Reply to this comment
Updated patch as suggested.
09/11/2007 Jan Schneider Comment #2
State ⇒ Feedback		 Reply to this comment
I think we should add the share unconditionally, like we already do it in the turba tree entry.

For the add links, how about making them sub entries from the current "new ..." entry, maybe also without a preference. Clicking directly on "new ..." would keep the old behavior unchanged, but you can also expand the tree below the icon to add add to a specific share directly.
09/11/2007 Gunnar Wrobel Comment #1
New Attachment: mnemo_tree-menu-links_20070911.patch
Queue ⇒ Mnemo
Priority ⇒ 1. Low
Summary ⇒ Adding quick links for adding notes to notepads
State ⇒ New
Type ⇒ Enhancement		 Reply to this comment
Thanks for the feedback on bug #5694.

I agree that adding the links to the tree menu actually more sense.

So this is another quick hack that implements this for mnemo.

This adds two new preferences: One activates a link per notepad that will lead to display of the contents of this specific notepad. The second preference activates the quick adding links and will open the "new note" dialog with the target notepad already selected.

If both preference are being activated the "Add" link will be a subelement of the notepad link.

This is just a draft and a request for comments. If it is okay this way I'd like to implement the same for nag, turba and kronolith.