Summary | Moving an event doesn't show error message if not permitted |
Queue | Kronolith |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | chuck (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 05/24/2007 (6614 days ago) |
Due | |
Updated | 05/25/2007 (6613 days ago) |
Assigned | |
Resolved | 05/25/2007 (6613 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Assigned to Chuck Hagenbuch
State ⇒ Resolved
The close() call was left over from the MCAL driver, which needed
mcal_close to be called to write things out properly. Now that we
don't need that (and we could handle it more intelligently anyways),
I've removed it. Thanks!
Priority ⇒ 1. Low
New Attachment: kronolith-fix-move-error-handling.patch
Queue ⇒ Kronolith
Summary ⇒ Moving an event doesn't show error message if not permitted
Type ⇒ Bug
State ⇒ Unconfirmed
moving an event doesn't show an error message if you don't have all
the needed permissions due a missing getEvent() call. The error
handling was a bit messy so I tried to improve it. I also added error
output for the case you don't have PERMS_DELETE in the source share.
Please see the attached patch.
I've a question about kronolith->close(). It's currently a dummy stub
for all Drivers, so what about removing it? I'm still wondering what
the original intention was directly after the move of the event to the
target share.
Thomas