Summary | Allow preauthenticate hook to modify parameters |
Queue | Horde Framework Packages |
Queue Version | HEAD |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | bklang (at) horde (dot) org |
Created | 09/23/2006 (6856 days ago) |
Due | |
Updated | 12/10/2009 (5682 days ago) |
Assigned | 11/09/2008 (6078 days ago) |
Resolved | 12/09/2009 (5683 days ago) |
Milestone | 4 |
Patch | No |
Assigned to Michael Slusarz
Taken from Ben Klang
State ⇒ Resolved
Assigned to Ben Klang
State ⇒ Assigned
State ⇒ Stalled
I looked into trying to do the same modification to Horde::callHook()
but it is not possible with PHP4. callHook() sets $args to a default
value of array(). If the function signature is changed to specify
$args as a pass-by-reference, a parse error is thrown. According to
the PHP documentation this is valid in PHP5 but not PHP4. Unless I'm
missing something, this change isn't going to be possible (at least,
not while maintaining backward compatibility).
State ⇒ Feedback
with callHook().
Priority ⇒ 1. Low
State ⇒ New
New Attachment: horde-hook-preauth-pbr.patch
Queue ⇒ Horde Framework Packages
Summary ⇒ Allow preauthenticate hook to modify parameters
Type ⇒ Enhancement
authentication. While the tobackend and frombackend hooks looked
appealing at first, they are not called in the appropriate locations
to be useable for this goal.
After discussing alternatives with Chuck, I settled on this approach:
Pass the values by reference to the preauthenticate hook. This will
allow rewriting of the parameters if required. The defualt case does
not do that so this should not impact BC. It does however let me
rewrite the username to include the domain name of the HTTP Vhost when
the user authenticates.