Summary | Don't dim signatures in quoted text |
Queue | Horde Framework Packages |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | Horde Developers (at) , slusarz (at) horde (dot) org |
Requester | selsky (at) columbia (dot) edu |
Created | 08/16/2006 (6911 days ago) |
Due | |
Updated | 10/13/2009 (5757 days ago) |
Assigned | 11/09/2008 (6095 days ago) |
Resolved | 10/13/2009 (5757 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 4 |
Patch | No |
State ⇒ Resolved
Bug #4299: Fix dimming signatures when mixed with quoted texthttp://git.horde.org/diff.php/framework/Text_Filter/lib/Horde/Text/Filter/Dimsignature.php?rt=horde-git&r1=a4821dba3cebdd907a36635ce22b9569ce35e32b&r2=85505a2a7397637aacfb9150f1b17d1a57618a7c
http://git.horde.org/diff.php/framework/Text_Filter/package.xml?rt=horde-git&r1=0a1dd0cd19b9adc33aea4d4f137b4d6b0aef4e8f&r2=85505a2a7397637aacfb9150f1b17d1a57618a7c
Summary ⇒ Don't dim signatures in quoted text
Taken from Michael Slusarz
Priority ⇒ 1. Low
single call or else we will run into issues with improperly closed
tags. But this can't be done until Horde 4 since it will break BC.
Priority ⇒ 2. Medium
changed from dimming everything below the first signature line to
dimming everything below the last signature line. It has nothing to
do with quoted vs. unquoted. The new algorithim makes more sense
because it won't result in an entire message being dimmed if the
signature appears on top. Not to start a holy war, but it is
definitely preferred etiquette to quote under previous text, so the
user's signature should *always* appear at the bottom of the message.
However, your message does bring up another issue - namely, we
shouldn't be dimming signatures in quoted text anyway if just for the
simple fact we start mixing closed/unclosed div/span tags and the page
won't render properly. i.e., in this case, pseudocode looks like this:
<div class="quoted1">
<div class="quoted2">
HTML
<span class="signature">
Signature
</div>
</div>
</span>
This is a severe limitation with the current Text_Filter scheme since
each filter doesn't (and can't) know if a previous filter has inserted
div/span tags that may intersect the current text. Yuck.
Possible solution - we have to do signature dimming in the highlight
quote filter. This would ensure we weren't setting a signature span
across quoted div's.
Priority ⇒ 1. Low
State ⇒ Assigned
Assigned to Michael Slusarz
Queue ⇒ Horde Framework Packages
Summary ⇒ Unquoted signature no longer dim
Type ⇒ Bug
longer dim. Quoted signatures are dim though.