6.0.0-beta1
7/18/25

[#4299] Don't dim signatures in quoted text
Summary Don't dim signatures in quoted text
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners Horde Developers (at) , slusarz (at) horde (dot) org
Requester selsky (at) columbia (dot) edu
Created 08/16/2006 (6911 days ago)
Due
Updated 10/13/2009 (5757 days ago)
Assigned 11/09/2008 (6095 days ago)
Resolved 10/13/2009 (5757 days ago)
Github Issue Link
Github Pull Request
Milestone 4
Patch No

History
10/13/2009 12:47:38 AM Michael Slusarz Assigned to Michael Slusarz
State ⇒ Resolved
 
11/09/2008 02:21:53 AM Chuck Hagenbuch State ⇒ Assigned
Summary ⇒ Don't dim signatures in quoted text
Taken from Michael Slusarz
 
12/26/2006 12:57:06 PM Jan Schneider State ⇒ Stalled
 
12/26/2006 06:04:09 AM Michael Slusarz Comment #3
Priority ⇒ 1. Low
Reply to this comment
As far as I can tell, we need to combine some filter algorithms into a 
single call or else we will run into issues with improperly closed 
tags.  But this can't be done until Horde 4 since it will break BC.
09/12/2006 06:03:29 PM Michael Slusarz Assigned to Horde DevelopersHorde Developers
 
08/17/2006 02:34:53 PM Michael Slusarz Comment #2
Priority ⇒ 2. Medium
Reply to this comment
Your issue is bogus.  The algorithim for dimming signatures recently 
changed from dimming everything below the first signature line to 
dimming everything below the last signature line.  It has nothing to 
do with quoted vs. unquoted.  The new algorithim makes more sense 
because it won't result in an entire message being dimmed if the 
signature appears on top.  Not to start a holy war, but it is 
definitely preferred etiquette to quote under previous text, so the 
user's signature should *always* appear at the bottom of the message.



However, your message does bring up another issue - namely, we 
shouldn't be dimming signatures in quoted text anyway if just for the 
simple fact we start mixing closed/unclosed div/span tags and the page 
won't render properly.  i.e., in this case, pseudocode looks like this:



<div class="quoted1">

<div class="quoted2">

  HTML

<span class="signature">

  Signature

</div>

</div>

</span>



This is a severe limitation with the current Text_Filter scheme since 
each filter doesn't (and can't) know if a previous filter has inserted 
div/span tags that may intersect the current text.  Yuck.



Possible solution - we have to do signature dimming in the highlight 
quote filter.  This would ensure we weren't setting a signature span 
across quoted div's.
08/16/2006 09:29:11 PM Matt Selsky New Attachment: MessageSource.eml Download
 
08/16/2006 09:28:39 PM Matt Selsky Comment #1
Priority ⇒ 1. Low
State ⇒ Assigned
Assigned to Michael Slusarz
Queue ⇒ Horde Framework Packages
Summary ⇒ Unquoted signature no longer dim
Type ⇒ Bug
Reply to this comment
With today's dimsignature changes in HEAD, my unquoted signature is no 
longer dim.  Quoted signatures are dim though.

Saved Queries