This is committed now. Turba needs to either be brought back to the 
mainline Share code, or get some other indeterminate fixes. But 
everything else seems okay. Great work, Gunnar!

All of the patches except the actual Share drivers are committed now, 
and I'm debugging those now (there seem to be some subtle bugs that I 
haven't tracked down yet). Turba is going to need some more work 
because it uses stuff in Share that other Groupware apps don't, but 
that should be its own ticket at this point for cleaning up the 
vbook/shared address book stuff.

While I did not change anythin within the code itself (besides an 
added error check) I did update the patches to the newest Horde 
version. There were only problems with the Kolab package because of 
the updates during the Auth patch I submitted a while ago.



So the current patch set should cleanly apply against Horde HEAD.



I did split the patch to the "horde" package. This would allow to 
apply the patches in a two step procedure:



  1) Splitting the Share driver by applying 
framework_Share-Kolab_Share_fix-20061220.patch and 
horde_config_conf.xml-Kolab_Share_fix-20061220.patch

  2) Adapting the Kolab parts to the new Share driver (the other three patches)



  Step 1) would split the share driver and provide a "datatree" and a 
"kolab" driver. This step should actually have no effect on anything 
related to Shares (at least as long as one chooses the "datatree" 
driver). Once this split has been tested and there are no problems, 
one could apply the last three patches to adapt the Kolab specific 
code to the new driver. I would then provide instructions for the 
Kolab community how to test the new code.



Maybe that helps. Thanks for your efforts!

Still on my todo list, but I won't mind if anyone else is audting and 
testing the patch.

What's the status of this one? If the patches are good we should get 
them committed so they don't go stale...

Sorry about the style problems. I should have given it a second pass.   
And I also did not check the datatree functionality for the latest 
version but only for the kolab server. Sorry again.



I tried to fix these problems and attatched a new patch for the Share 
directory. I hope the datatree side of things is clean now. The 
kolab.php driver still carries some fixme's though these should not be 
functionaly  but structural problems.

I cleaned it up but still didn't get it working. Attached is the 
current version, please be more strict with the coding standards in 
the future (indention, tabs, curly braces). Did you test your patch 
with a non-Kolab setup?

Since I switched to Horde CVS now and fixed some minor bugs on the new 
share driver, I did prepare an updated patch set. Please remove the 
old patch files.



Thanks!

* turba-Kolab_Shares_fix-20061115.patch



   Patches the turba package to work together with the new share driver.

* horde_config-Kolab_Share_fix-20061115.patch



   Patches the horde package to work together with the new share driver.

* framework_Kolab_Kolab.php-Kolab_Share_fix-20061115.patch



   A patch to convert the Kolab driver to the new kolab share driver

* framework_Share_Share_kolab.php-Kolab_Share_fix-20061115



   Provides the Share kolab driver.

* framework_Share_Share_datatree.php-Kolab_Share_fix-20061115



   Provides the Share datatree driver.

* framework_Share_Share.php-Kolab_Share_fix-20061115.patch



   Allows the Share system to use different driver types instead

   of just relying on the datatree system.

Done. I've deleted the patches that are now completely committed just 
to consolidate the ticket a bit.

Chuck, can you take a look at the rawurlencode() stuff, I'll take care 
of the Share code?

Then I guess in addition to these changes, we will also need to 
implement configuration options that allow per-application share 
backend selection?

Ahem, no, that wouldn't scale well :)



On the other hand having a specific kolab share driver is not so much 
about supporting horde apps like ansel. It is mainly centered towards 
turba, mnemo,nag and kronolith.



The reason for suggesting a specific kolab driver is the fact that 
kolab is based on this IMAP-centric model and IMAP is  the storage 
backend used for all kolab groupware information.



So the original Kolab driver tries to bridge between the IMAP 
information and the datatree storage and constantly syncs from one to 
the other. And this actually never really worked.



So having this specific share driver helps with kolab, but it will not 
be the most efficient choice for having large image galleries in an 
e-mail based storage system.

Just wondering how well using Kolab as a storage backend for shares 
will scale.  I know really nothing about Kolab or using IMAP as a 
datastore so to speak, just curious.



For example, in one installation I have dedicated datatree tables for 
storing Ansel galleries and images...the horde_datatree_ansel table 
has well over 20000 entries alone, and the matching attributes table 
obviously has *much* more than this.

Kronolith, nag, mnemo and turba use the htmlspecialchars() function to 
encode the share id, while using rawurlencode in the java snippet that 
provides the list of available shares. Since the share ids in the 
kolab driver include a "/" character the resulting ids did not match.

Modified share configuration and removed kolab hooks.

In order to have better kolab support it would be nice to split the 
current Share module so that it supports different driver types.



The attached patches are only a first draft to get some comments on 
the structure of the code. Please criticize everything you feel is 
incorrect or has an inappropriate structure. I'm not really a horde 
expert so I assume that I probably violated some of the concepts of 
the horde framework.



Thanks for any comments!