Tickets :: [#4098] [patch] addAttribute API call doesn't check ticket validity

Summary	[patch] addAttribute API call doesn't check ticket validity
Queue	Whups
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	bklang (at) horde (dot) org
Created	07/01/2006 (7051 days ago)
Due
Updated	07/03/2006 (7049 days ago)
Assigned
Resolved	07/03/2006 (7049 days ago)
Milestone
Patch	No

07/03/2006 01:43:11 AM	Chuck Hagenbuch	Comment #2 State ⇒ Resolved	Reply to this comment
Committed, with very minor changes. I think the only one worth mentioning is that gettext calls (the _() bits) need double quotes; otherwise the gettext tools don't pick up the strings for translation.

07/02/2006 06:06:25 AM	Ben Klang	Summary ⇒ [patch] addAttribute API call doesn't check ticket validity

07/01/2006 03:20:07 AM	Ben Klang	Comment #1 State ⇒ New Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ addAttribute API call doesn't check ticket validity Queue ⇒ Whups New Attachment: whups-addAttribute-descriptive-errors.patch	Reply to this comment
This was a "FIXME" in the code. When an attribute change is attempted the ticket isn't validated for existence or permission before the modification. This patch implements that check. It also removes a redundant check for arg presence and changes the error messages to be more helpful.