I am trying to get this fix applied at my hosting company. Can you 
tell me how this fix is applied and where to find the fix?



Thanks

Worked around by adding an empty paragraph in front of the signature 
so that you focus the cursor outside the signature.

I just tried again and I still can't reproduce this. Jan, can you 
please try, since you're the one seeing it?

I think the issue is, that if you start typing a html message, the 
typed characters go *after* the comment, because the <p> with the 
signature is the first element in the dom, so that's where you end up, 
if the cursor gets the focus in the wysiwyg editor.

I'm not having any luck reproducing this. My guess is that somewhere 
there's a regex that's too greedy, though - can you maybe look at the 
HTML source and see if the html comments we're using to delimit the 
signature are being put around too much text?

Happens only with HTML. If I get a reply to one of my messages with my 
message including my signature quoted, and then reply again to that 
message, and then switch the identity, not only my bottom-most 
signature is replaced, but large parts of the message disappear. 
Probably everything from the first (quoted) appearance of my 
signature, to the last.

I'm not positive I follow. Can you give me an example of that? And 
does that happen in the HTML editor only, or in plain text as well?

This change breaks messages where the signature happens to be inside 
the message body, e.g. in a longer thread where the original signature 
has been quoted.

I think I've nailed this now, using a marker comment instead of a div.

Other than it might be a bit difficult to catch via regex when 
switching modes (?)  Then again, I guess we already kind of do this in 
javascript code currently so maybe it wouldn't be that hard.

Is there a reason that we wouldn't want to do a <div 
class="emailSignature"></div>, then?

I'm sure we already have a ticket for that, but I can't find it. The 
problem is that browsers (at least Gecko) are returning different HTML 
code each time you request it, when using the WYSIWYG editor. Thus we 
can't find the HTML code we need to replace the signature.

If the  composition editor is in HTML mode, switching identities 
doesn't switch the signature.



I can replicate this in IMP 4.0.4 and 4.1