Summary | procmail forwarding may cause mail loops |
Queue | Ingo |
Queue Version | 1.0.2 |
Type | Enhancement |
State | Resolved |
Priority | 2. Medium |
Owners | Horde Developers (at) , jan (at) horde (dot) org |
Requester | joshkel (at) gmail (dot) com |
Created | 02/17/2006 (7083 days ago) |
Due | |
Updated | 05/23/2006 (6988 days ago) |
Assigned | 05/23/2006 (6988 days ago) |
Resolved | 05/23/2006 (6988 days ago) |
Milestone | |
Patch | Yes |
State ⇒ Resolved
State ⇒ Assigned
Priority ⇒ 2. Medium
New Attachment: vacation_loop.patch
Sorry it took me so long to take care of this.
State ⇒ Feedback
Priority ⇒ 1. Low
source of the code and the permission to redistribute it in the
comments?
current patch. From further discussion by mail:
From: Jari Aalto <jari.aalto@cante.net>
To: Josh Kelley <joshkel@gmail.com>
Date: Apr 17, 2006 9:49 AM
Subject: Re: Licensing question - sharing Apache and GPL code
(pm-lib/Ingo/Horde)
| On 4/4/06, Jari Aalto <jari.aalto@cante.net> wrote:
| > The licensing issues are complex matter and I would rather suggest to
| > make an informed decision:
| >
| > - practical; just take the code and quote me
| > in the project files: "The Ingo project
| > has the permission to use Procmail Library code
| > under Apache licence v 1.x or any later version.
| > Permission obtained 2006-04-04 from Author Jari Aalto."
|
| Since the Horde developers have said that they prefer this approach,
| is it okay if we proceed with it?
|
| Thank you for all of your time spent on this.
Sure, please go ahead,
Jari
Hi Josh, Jari,
Zitat von Josh Kelley <joshkel@gmail.com>:
ten lines of procmail recipe code (iirc) which is not really rocket
science. This would of course be a completely different story if we
were about to include large parts of, or the complete pm-lib.
And it's similar to how we did handle inclusion of other third party
code or algorithms with written permission by the author.
that we can agree on.
- Long route; take the issue to the development team
(upstream; Ingo, Horde devel) and have a discussion to
persuate them to move to Apache 2.x licence or have them
add wording "Apache 1.x lincence or at your option
any later version" as GPL does.
with any licence like ASL here. But since contributors don't
explicitely hand the copyright over to the Horde Project (which
doesn't exist as a legal entity anyway), we probably can't simply
change the licence without the permission of each single contributor.
Jan.
New Attachment: vacation_loop.diff
ask the author or find a different solution.
Attached is my cleaned up version of you patch with several coding
standards fixes. Please continue from there.
exactly does this mean?
pm-lib.sourceforge.net contains a procmail snippet for determining the
from address without making an extra call to formail, so I used it.
(This makes up the 13 lines or so of code that set OUTPUT.) I just
realized that pm-lib is GPL'ed and Horde is LGPL'ed, so maybe it
wasn't appropriate to do this; if you'd like me to rework the patch or
contact pm-lib's author for permission, please let me know. (Sorry,
I'm not very familiar with the process for including code snippets
from one open source project in another.)
Assigned to Jan Schneider
Taken from ben
State ⇒ Feedback
exactly does this mean?
more message looping since I patched with this, so thanks a lot for
this patch and I vote to make it a part of official code.
take care of committing it.
State ⇒ Assigned
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
New Attachment: ingo-forwards.patch
Queue ⇒ Ingo
Summary ⇒ procmail forwarding may cause mail loops
Type ⇒ Bug
against mail loops if the forwarded-to address is bad or if it
forwards back to this address. The attached patch should fix the
problem.
The patch still has one bug, described in the comments.
I'm no procmail expert, but we've been running this patch for a few
months with no complaints.