Tickets :: [#3434] Attachment size percentile indicator

6.0.0-beta1

7/12/25

Summary	Attachment size percentile indicator
Queue	IMP
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	mp (at) xmission (dot) com
Created	02/08/2006 (7094 days ago)
Due
Updated	10/16/2006 (6844 days ago)
Assigned
Resolved	10/16/2006 (6844 days ago)
Milestone
Patch	Yes

10/16/2006 10:02:32 AM	Jan Schneider	Comment #10 State ⇒ Resolved	Reply to this comment
Committed, thanks.

10/16/2006 10:01:59 AM	Jan Schneider	Deleted Original Message

10/16/2006 10:01:23 AM	Jan Schneider	Deleted Original Message

10/16/2006 10:01:00 AM	Jan Schneider	Deleted Original Message

10/15/2006 11:23:36 PM	ekg2002 (at) columbia (dot) edu	Comment #9 New Attachment: attach_perc4.diff	Reply to this comment
Just kidding. See update patch at attach_perc4.diff. Apologies for the extra traffic.

10/15/2006 11:08:14 PM	ekg2002 (at) columbia (dot) edu	Comment #8 New Attachment: attach_perc3.diff	Reply to this comment
Comments integrated into patch. See attach_perc3.diff

10/11/2006 08:05:36 PM	ekg2002 (at) columbia (dot) edu	Comment #7	Reply to this comment
Ooops. I forgot about this since classes have started. I will do this ASAP.

10/10/2006 02:25:41 PM	Jan Schneider	Comment #6	Reply to this comment
Are you going to update the patch?

08/07/2006 10:01:33 PM	Jan Schneider	Comment #5	Reply to this comment
Sorry to be picky about this small patch, but I think building the gettext string in compose.php makes more sense because, a) it's easier for translators to translate with positional parameters, and b) you can use a single template variable for the if-tag and the content tag.

08/06/2006 12:52:39 AM	ekg2002 (at) columbia (dot) edu	Comment #4 New Attachment: attach_perc2.diff	Reply to this comment
the comments are implemented and appreciated. See new attachment.

07/31/2006 11:20:39 AM	Jan Schneider	Comment #3 State ⇒ Feedback	Reply to this comment
Looks good, but I have a few suggestions: - Use gettext for the string, either in the template, or by using sprintf(_("")) in compose.php. - Don't concat the absolute and relative sizes with a comma, this is the decimal separator in a lot of languages and looks weird. A slash is probably better.

07/31/2006 02:25:28 AM	ekg2002 (at) columbia (dot) edu	Comment #2 New Attachment: attach_perc.diff	Reply to this comment
Will this patch be sufficient?

02/08/2006 11:00:13 PM	Jan Schneider	State ⇒ Accepted Priority ⇒ 1. Low

02/08/2006 07:08:51 PM	mp (at) xmission (dot) com	Comment #1 Priority ⇒ 2. Medium State ⇒ New Queue ⇒ IMP Summary ⇒ Attachment size percentile indicator Type ⇒ Enhancement	Reply to this comment
We've had a suggestion, which I think is a good one, to add a very simple indicator to the compose window which tells the user what percentage of the maximum attachment size limit has been used by current attachments. This would sit perhaps to the right of 'Total attachment size' and say something like '80% of maximum message size'.