[#3076] show log info when hovering a revision in the annotate screen
| Summary | show log info when hovering a revision in the annotate screen |
| Queue | Chora |
| Queue Version | HEAD |
| Type | Enhancement |
| State | Resolved |
| Priority | 2. Medium |
| Owners | Horde Developers |
| Requester | robzilla (at) siklos (dot) ca |
| Created | 12/01/2005 (898 days ago) |
| Due | |
| Updated | 03/04/2006 (805 days ago) |
| Assigned | 01/03/2006 (865 days ago) |
| Resolved | 03/04/2006 (805 days ago) |
| Attachments | 3076-v5.patch  |
| Milestone | |
| Patch |
State ⇒ Resolved
I cleaned things up a bit, but it looked pretty good. We did put you through a lot of revisions. :) In general it'd be great if you took a quick look at the differences between what you had and what I committed and at horde/docs/CODING_STANDARDS. Mainly we don't use # for comments, but a few spacing things as well. But all minor.
Thanks!
Assigned to
New Attachment: 3076-v5.patch
Ok, this patch should be good to go.
I put all the nasty JavaScript in chora/templates/annotate/footer.inc (instead of header.inc), since it depends on some php variables that get defined after header.inc is sourced.
I know the JS is ugly - I tried to make it as readable as possible, but if anyone has any suggestions on cleaning it up, I'd be happy to make changes.
> 1) Where should all the JS code that I put in annotate.php ?
Put it into chora/templates/annotate/header.inc
> 2) What to do about the "unclickable url-in-the-toolip" issue?
Don't create them. This would reduce the payload even more.
New Attachment: 3076-v4.patch
Here's a patch that's complete, as far as I can tell.
However it's not ready to go. Here's what I still don't know:
1) Where should all the JS code that I put in annotate.php ?
2) What to do about the "unclickable url-in-the-toolip" issue?
Thanks.
New Attachment: 3076-v3.patch
Ok, here's another patch, It's not polished (by a long shot), but I just want to make sure I'm on the right track.
I think I'm doing everything right, except there is still no way to click on a link in the tooltip, and I don't know how to fix this (separate bug?)
Also, I'm not sure how to implement the EventCache::remove() function in horde.js - can anyone help me with this? Because I haven't implemented this, my patch won't work with IE (but it works fine with Mozilla and the like)
Much better, but please take a short ride through docs/TRANSLATION and watch out especially for quotes, xhtml, and horizontal whitespace.
And there is still a major concern regarding page size. This patch adds the complete changelog message (including markup) for *every* line of the code which could easily double the page size, if not more.
A solution would be to not add the title to each revision link, but create some fancy javascript that is called onload, that goes through all revision links and sets the titles from a js array with all changelog messages, indexed by revision.
New Attachment: 3076-v2.patch
ok, disregard my last comment - i found everything I needed. Sooo nice to have such a handy framework with all this stuff already coded.
However, I still have doubts:
1) if the cvs log message contains a link to the bug tracking system, that link is not clickable (since when you move your mouse to click on it, the tooltip will disappear)
2) I'm not sure if the code that calls the tooltip function belongs in the script or the template.
** new patch - 3076-v2.patch **
> You should use the link title/tooltip code from CVS instead
Can you tell me where to find this code, or better yet, point me to an example of it somewhere in existing code?
State ⇒ Feedback
The idea is very nice, but the implementation is awful! ;-)
You should use the link title/tooltip code from CVS instead, and create the necessary title attributes on page load.
Queue ⇒ Chora
Summary ⇒ show log info when hovering a revision in the annotate screen
Type ⇒ Enhancement
Priority ⇒ 2. Medium
New Attachment: logmsg.patch
State ⇒ New
When viewing the annotation of a file, it is very helpful to know what the log message is for the various revisions that appear.
When hovering the mouse over a revision in the annotation screen, a box should appear showing the log message (plus other info).
** Patch attached **