[#2549] Reporting multiple messages as spam fails
Summary Reporting multiple messages as spam fails
Queue IMP
Queue Version 4.0.4-RC1
Type Bug
State Resolved
Priority 1. Low
Owners
Requester horde (dot) org (at) spamvrij (dot) kicks-ass (dot) org
Created 09/02/2005 (1224 days ago)
Due
Updated 09/03/2005 (1223 days ago)
Assigned
Resolved 09/03/2005 (1223 days ago)
Attachments IMP-H3-404-RC1-Spam.php.diff Download
Milestone
Patch No

History
09/03/2005 Matt Selsky Comment #2
State ⇒ Resolved		 Reply to this comment
Committed to 4.0.4 and HEAD, thanks.
09/02/2005 horde (dot) org (at) spamvrij (dot) kicks-ass (dot) org Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Reporting multiple messages as spam fails
State ⇒ Unconfirmed
Queue ⇒ IMP
New Attachment: IMP-H3-404-RC1-Spam.php.diff Download		 Reply to this comment
Symptom description: When using a 'spam reporting email address' is 
set and multiple messages are selected in the message-list and 
reported to the system administrator, then only the first message is 
reported, and instead of just once, it's done for the number of 
selected messages.

Problem description: The variable $raw_msg in imp/lib/Spam.php is only 
retrieved once, because the code checks for !isset($raw_msg).

Solution: either reset the variable after the loop, or give a 
null-value at loop-start. I found the bug in IMP-H3-4.03 and made a 
private fix. The bug is still present in IMP-H3-4.0.4RC1. Attached is 
a diff suggestion for 4.0.4RC1 (using diff -uNr).

Grtz, Paul Molensky