6.0.0-beta1
7/10/25

[#2324] Override VFS username and password (patch)
Summary Override VFS username and password (patch)
Queue Ingo
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester maddog2k (at) maddog2k (dot) net
Created 07/23/2005 (7292 days ago)
Due
Updated 07/29/2005 (7286 days ago)
Assigned
Resolved 07/28/2005 (7287 days ago)
Milestone
Patch No

History
07/29/2005 01:15:38 PM maddog2k (at) maddog2k (dot) net Comment #8 Reply to this comment
Hereby confirmed that everything works as expected :)
07/29/2005 09:10:17 AM Jan Schneider Comment #7 Reply to this comment
You renamed function substVars to _substVars, but the calls to this
function are still '$this->substVars()'. Also, you forgot to fill
Fixed.
$this->_params['username'] and ['password'] with the values of
['vfs_user'] and ['vfs_pass'], since those variables are used by the
VFS driver.

Perhaps it would be cleaner to not use 'vfs_user' & 'vfs_pass', but
to use 'username' and 'password'. But that's up to you :)
That's what I did. It doesn't make sense to use different keys for 
these values.
07/28/2005 08:22:27 PM maddog2k (at) maddog2k (dot) net Comment #6
New Attachment: vfs-fix.patch Download
Reply to this comment
Hi,



You broke 2 things:



You renamed function substVars to _substVars, but the calls to this 
function are still '$this->substVars()'. Also, you forgot to fill 
$this->_params['username'] and ['password'] with the values of 
['vfs_user'] and ['vfs_pass'], since those variables are used by the 
VFS driver.



Perhaps it would be cleaner to not use 'vfs_user' & 'vfs_pass', but to 
use 'username' and 'password'. But that's up to you :)



I've added a fix for the 2 problems above.
07/28/2005 02:02:29 PM Jan Schneider Comment #5
State ⇒ Resolved
Reply to this comment
Cleaned up and committed. I didn't test it, so please try if my 
changes still work.
07/28/2005 09:57:20 AM maddog2k (at) maddog2k (dot) net Comment #4
New Attachment: horde_ingo-override_vfs[2].diff Download
Reply to this comment
W00ps,



I messed up the previous patch. Here 's the final one :)
07/28/2005 09:47:29 AM maddog2k (at) maddog2k (dot) net Comment #3
New Attachment: horde_ingo-override_vfs[1].diff Download
Reply to this comment
The vfs_user and vfs_pass were already 'optional', but I've changed it 
as you requested :)



Also, you were right about the broken writeData().

I missed the line when merging the patch with the 'clean' source :)



I've adjusted this in the new patch, making all the variables optional.



Hopefully you will be satisfied with this one :)
07/25/2005 03:32:21 PM Jan Schneider State ⇒ Feedback
 
07/25/2005 03:32:07 PM Jan Schneider Comment #2
State ⇒ Accepted
Reply to this comment
Please change the patch to make the vfs_user and vfs_pass optional, 
i.e. commented out in backends.php.dist by default, and checked with 
empty() in vfs.php.

And you break existing system with writeData() change in vfs.php. I 
see where you're heading at, but this should solved more elegantly, 
and most important, backward compatible.
07/23/2005 12:04:01 PM maddog2k (at) maddog2k (dot) net Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Override VFS username and password (patch)
Queue ⇒ Ingo
New Attachment: horde_ingo-override_vfs.diff Download
State ⇒ New
Reply to this comment
I've made a small patch against ingo-HEAD-2005-07-22, that allows an 
override of the username & password used for VFS.



It still defaults to '$username' and '$password' as it currently does.



I needed this because all my mail-accounts are virtual and under the 
same uid+gid.

Saved Queries