Summary | Add support for recurring tasks |
Queue | Nag |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | kevin_myer (at) iu13 (dot) org |
Created | 06/17/2005 (7312 days ago) |
Due | |
Updated | 08/29/2012 (4682 days ago) |
Assigned | 11/06/2008 (6074 days ago) |
Resolved | 04/02/2012 (4831 days ago) |
Milestone | 4 |
Patch | No |
commit 563421795d6e9a6a7d5fa552643b90e04fc87d3d
Author: Jan Schneider <jan@horde.org>
Date: Mon Apr 2 19:59:02 2012 +0200
Add recurring tasks - frontend part, ajax only (
Request #2150).kronolith/docs/CHANGES | 2 +-
kronolith/js/kronolith.js | 184 ++++++++++++++++++---------
kronolith/lib/Ajax/Application.php | 37 +++---
kronolith/lib/Event.php | 252
+++++++++++++++++++-----------------
kronolith/lib/Event/Horde.php | 11 ++-
kronolith/lib/Kronolith.php | 4 +
kronolith/templates/index/task.inc | 58 ++++++++
nag/docs/CHANGES | 1 +
nag/lib/Api.php | 24 ++++
nag/lib/Driver.php | 23 ++++
nag/lib/Task.php | 22 +++-
nag/package.xml | 1 +
12 files changed, 413 insertions(+), 206 deletions(-)
http://git.horde.org/horde-git/-/commit/563421795d6e9a6a7d5fa552643b90e04fc87d3d
commit 6bb5bcc17e44b2defa22896aa4c55489bb19e09a
Author: Jan Schneider <jan@horde.org>
Date: Mon Apr 2 14:05:00 2012 +0200
Add recurring tasks - backend part (
Request #2150).nag/app/controllers/CompleteTask.php | 8 +--
nag/lib/Api.php | 10 +--
nag/lib/Driver.php | 7 ++-
nag/lib/Driver/Kolab.php | 17 +++++
nag/lib/Driver/Sql.php | 109
++++++++++++++++++++++++++--
nag/lib/Task.php | 93 +++++++++++++++++++++++-
nag/migration/9_nag_upgrade_recurrence.php | 4 +
nag/test/Nag/Unit/Driver/Base.php | 23 ++++++
8 files changed, 243 insertions(+), 28 deletions(-)
http://git.horde.org/horde-git/-/commit/6bb5bcc17e44b2defa22896aa4c55489bb19e09a
State ⇒ Resolved
commit 563421795d6e9a6a7d5fa552643b90e04fc87d3d
Author: Jan Schneider <jan@horde.org>
Date: Mon Apr 2 19:59:02 2012 +0200
Add recurring tasks - frontend part, ajax only (
Request #2150).kronolith/docs/CHANGES | 2 +-
kronolith/js/kronolith.js | 184 ++++++++++++++++++---------
kronolith/lib/Ajax/Application.php | 37 +++---
kronolith/lib/Event.php | 252
+++++++++++++++++++-----------------
kronolith/lib/Event/Horde.php | 11 ++-
kronolith/lib/Kronolith.php | 4 +
kronolith/templates/index/task.inc | 58 ++++++++
nag/docs/CHANGES | 1 +
nag/lib/Api.php | 24 ++++
nag/lib/Driver.php | 23 ++++
nag/lib/Task.php | 22 +++-
nag/package.xml | 1 +
12 files changed, 413 insertions(+), 206 deletions(-)
http://git.horde.org/horde-git/-/commit/563421795d6e9a6a7d5fa552643b90e04fc87d3d
commit 6bb5bcc17e44b2defa22896aa4c55489bb19e09a
Author: Jan Schneider <jan@horde.org>
Date: Mon Apr 2 14:05:00 2012 +0200
Add recurring tasks - backend part (
Request #2150).nag/app/controllers/CompleteTask.php | 8 +--
nag/lib/Api.php | 10 +--
nag/lib/Driver.php | 7 ++-
nag/lib/Driver/Kolab.php | 17 +++++
nag/lib/Driver/Sql.php | 109
++++++++++++++++++++++++++--
nag/lib/Task.php | 93 +++++++++++++++++++++++-
nag/migration/9_nag_upgrade_recurrence.php | 4 +
nag/test/Nag/Unit/Driver/Base.php | 23 ++++++
8 files changed, 243 insertions(+), 28 deletions(-)
http://git.horde.org/horde-git/-/commit/6bb5bcc17e44b2defa22896aa4c55489bb19e09a
Taken from Gunnar Wrobel
Milestone ⇒ 4
Version ⇒ Git master
Milestone ⇒ 3.1
State ⇒ Assigned
Patch ⇒ No
State ⇒ Feedback
renderer still includes HTML code that doesn't belong there. Field
renderers must only contain the code for the actual fields. You add
all kind of form row layout that is the job of the form renders (as
opposed to the field renderer). If you want to add more then one
(html) field in the form field renderer, separate them by simple
breaks, or what ever fit your needs, but don't re-use or interrupt the
regular form rendering with tables (because other renderers than the
default might use a different rendering technique than tables).
State ⇒ Assigned
New Attachment: HK-GW-Recurrence[3].patch
I added the required JavaScript functionality now. So the patch should
be complete feature wise.
I'm still a layman when it comes to JS and Horde Forms. So there might
be some JS corrections necessary. As usual I'm open to suggestions :)
Thanks!
New Attachment: HK-GW-Recurrence[2].patch
There are some java script issues left and the whole recurrence part
should only be shown if there exists a due date for the task. Maybe it
is already okay for a first commit and some polishing in CVS.
http://cvs.horde.org/co.php/nag/lib/Recurrence.php?r=1.1
Util::getFormData() and Nag_Recurrence instead of
Horde_Date_Recurrance. And we probably have to use different constant
names to avoid collisions when showing tasks in Kronolith. I just see
you already did this, but you don't use them everywhere yet.
Either you need different form fields for the different recurrence
settings, or you have to implement the complete widget in a single
cell, like any other form field.
renderers work.
instance. Instead, you should store the completion of a single
recurrence, similar to how exceptions are stored at the moment. And
of course we should (at some point, not necessarily from the start)
add the ability to actually create exceptions.
New Attachment: HK-GW-Recurrence[1].patch
instance. Instead, you should store the completion of a single
recurrence, similar to how exceptions are stored at the moment. And
of course we should (at some point, not necessarily from the start)
add the ability to actually create exceptions.
support in recurrences as
bug #7029Patch ⇒ Yes
State ⇒ Feedback
Milestone ⇒ 3
Util::getFormData() and Nag_Recurrence instead of
Horde_Date_Recurrance. And we probably have to use different constant
names to avoid collisions when showing tasks in Kronolith. I just see
you already did this, but you don't use them everywhere yet.
The varrenderers won't work the way you implemented them though.
Either you need different form fields for the different recurrence
settings, or you have to implement the complete widget in a single
cell, like any other form field.
And you shouldn't create new tasks when completing one recurrence
instance. Instead, you should store the completion of a single
recurrence, similar to how exceptions are stored at the moment. And of
course we should (at some point, not necessarily from the start) add
the ability to actually create exceptions.
But beside that, it looks very promising, nice work!
New Attachment: HK-GW-Recurrence.patch
for the kolab driver so far. Does this go into the right direction?
Priority ⇒ 1. Low
State ⇒ New
Queue ⇒ Nag
Type ⇒ Enhancement
Summary ⇒ Add support for recurring tasks
to use the recurrence portion of the iCalendar spec.