Summary | Email Alarm Text is Ambiguous |
Queue | Kronolith |
Queue Version | 2.0.3-RC1 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | Horde Developers (at) |
Requester | derek (at) battams (dot) ca |
Created | 04/24/2005 (7481 days ago) |
Due | |
Updated | 05/01/2005 (7474 days ago) |
Assigned | 04/24/2005 (7481 days ago) |
Resolved | 05/01/2005 (7474 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
State ⇒ Assigned
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Email Alarm Text is Ambiguous
Queue ⇒ Kronolith
ambiguous. My patch for
bug 1356included a fix for this, butobviously wasn't included in the commit. The current text reads:
sprintf(_("You requested to be reminded about %s, which is at %s."),
$event->title, date('H:i', $event->start->timestamp()))
Since
bug 1356addressed fixing reminders such that they are sent atthe appropriate time, which may be days before the event in question,
the text can be quite misleading. For example, if an alarm is set for
48 hours before an event you will get the above text in an email
reminder, which could read:
"You requested to be reminded about Appointment X, which is at 09:30."
However, with the patch for 1356, this event may actually be scheduled
for 09:30 two days from now, but this email suggests that the event is
today at 09:30. The quickest fix, as provided in my patch for 1356,
is to simply add the date of the event along with the time in the
date() call. Of course, there is probably a better, more complete
text that could be written.
Marked as medium because the text of the emails as sent can be
misleading as to the actual date/time of the event for which the alarm
is being sent about.