6.0.0-beta1
7/11/25

[#1650] Add turba preference to set which addressbooks to display
Summary Add turba preference to set which addressbooks to display
Queue Turba
Queue Version 2.0.2
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester kevin_myer (at) iu13 (dot) org
Created 03/30/2005 (7408 days ago)
Due
Updated 06/09/2005 (7337 days ago)
Assigned
Resolved 06/09/2005 (7337 days ago)
Milestone
Patch No

History
06/09/2005 09:24:51 PM Chuck Hagenbuch State ⇒ Resolved
 
06/09/2005 02:35:44 AM kevin_myer (at) iu13 (dot) org Comment #16 Reply to this comment
Logically this makes sense to me. Unfortunately it's also a
compatibility break with the possibility to be very subtle and
annoying. I think what you should do, and even perhaps what we should
do by default or recommend, is to lock the existing preferences in
IMP and Kronolith and use a preferences hook to retrieve the Turba
default_dir value when those prefs are requested.
Exactly what I had just typed out before I tried to use the 
non-existent Tabbed Browsing feature of Whups to reference back to 
your comment and lost it all :)



Even though you do that, you still have the issue that your 
'add_source' in IMP is weighted higher than the order you've selcted 
for 'addressbooks' in Turba.  In my mind, add_source is only defining 
which addressbook you want to save addresses to and it should not be 
the default selection.  In fact, you may not even have it selected as 
an addressbook to display.  The first addressbook in the Turba 
'addressbooks' option should be selected.  That's what users expect, 
because I had configured localsql to be first and _everyone_ wanted 
our main directory first in Turba.  And they want that in IMP too.   
Thats also where the idea that all Address Book related stuff should 
be set in Turba and then the only option set within each module that 
uses Turba would be exactly how the data made available from those 
sources is used (like what fields to search, for IMP).  I myself 
thought that the address books selected in IMP controlled what showed 
up in the Address Book available from the IMP compose screen but they 
only control name expansion functions.
Think we can resolve this ticket?
Sure, every ticket is resolvable with enough resources.  Oh, you mean 
was the original spirit of the ticket resolved?  If IMP's contacts 
screen behaves properly, I'd say yes. ;)
06/09/2005 02:17:55 AM Chuck Hagenbuch Comment #15 Reply to this comment
Now addressbooks are also options that can be set in IMP and in
Kronolith.  IMP's got a 'add_source', which in my mind is going to be
the same as Turba's 'default_dir'.  IMP and Kronolith both have
address book selection widgets.  Would it be a stretch to fold all
address book selection into Turba, and leave IMP's address book
option simply be what columns out of the selected addressbook(s) do
you want searched for address expansion?  And do away with address
book selection in Kronolith altogether?
Logically this makes sense to me. Unfortunately it's also a 
compatibility break with the possibility to be very subtle and 
annoying. I think what you should do, and even perhaps what we should 
do by default or recommend, is to lock the existing preferences in IMP 
and Kronolith and use a preferences hook to retrieve the Turba 
default_dir value when those prefs are requested.



Think we can resolve this ticket?
06/09/2005 02:15:46 AM Chuck Hagenbuch Comment #14 Reply to this comment
One remaining issue - IMP still appears to be defaulting to the
'add_source' as the selected addressbook, although it pulls them in
from Turba in the proper order.
Well, as long as IMP still has its own preference that seems like 
reasonable behavior to me...
06/08/2005 02:37:45 AM kevin_myer (at) iu13 (dot) org Comment #13 Reply to this comment
One remaining issue - IMP still appears to be defaulting to the 
'add_source' as the selected addressbook, although it pulls them in 
from Turba in the proper order.
06/08/2005 02:35:15 AM kevin_myer (at) iu13 (dot) org Comment #12 Reply to this comment
I think thats intuitive now.  Let's you maintain backwards 
compatibility, and lets you move forward as well.



Now addressbooks are also options that can be set in IMP and in 
Kronolith.  IMP's got a 'add_source', which in my mind is going to be 
the same as Turba's 'default_dir'.  IMP and Kronolith both have 
address book selection widgets.  Would it be a stretch to fold all 
address book selection into Turba, and leave IMP's address book option 
simply be what columns out of the selected addressbook(s) do you want 
searched for address expansion?  And do away with address book 
selection in Kronolith altogether?



If the answer to the question of "when would you need a smaller subset 
of your choices in Turba, within an application?" is never, then it 
makes sense :)  And I know it makes sense in our environment but I 
hate to generalize that, because there's always something that I 
didn't consider.
06/06/2005 03:31:39 AM Chuck Hagenbuch Comment #11 Reply to this comment
Try now?
06/02/2005 09:55:42 PM kevin_myer (at) iu13 (dot) org Comment #10 Reply to this comment
Perfect (after I reread the comment a few times).  'addressbooks' 
should control the order of and which addressbooks are displayed.   
'default_dir" should control where you save your stuff (or at least 
that was how I was expecting it to behave originally).  That 
accomodates the situation where 'default_dir' is not included in the 
'addressbooks' list, which would cause my earlier assumption about 
having the first one be 'default_dir', to break.  And you're right, 
its not intuitive that the first one is 'default_dir'.
06/02/2005 09:34:52 PM Chuck Hagenbuch Comment #9
State ⇒ Feedback
Reply to this comment
I think it's unintuive to users to use the ordering to pick the 
default "add" addressbook.



So, how about we move the preference to the new addressbook selection 
page, word it so it's clear that it'll be the default address book for 
adding contacts to, and make sure that default_dir doesn't affect the 
order of any dropdowns?
06/02/2005 09:22:52 PM kevin_myer (at) iu13 (dot) org Comment #8 Reply to this comment
Duh on the double quote/single quote.  I even noticed that last night 
(thanks to vi's syntax highlighting" but thought nothing of it :)



I think I got the display and selection of addressbooks figured out.   
I was assuming that default_dir had to be an addressbook you had to 
have write access to, based on the wording (since you can't create 
contact lists, for example, in a read-only LDAP directory).  Just my 
opinion but that should be folded into the addressbook preferences 
group and maybe even be made part of the selection code.  Whatever you 
select as your first addressbook becomes your default_dir, because I 
think its kind of redundant to choose the order and which addressbooks 
to display, and then to separately choose a default address book.




06/02/2005 08:57:05 PM Chuck Hagenbuch Comment #7 Reply to this comment
1)  What's the syntax for setting a default preference for
'addressbooks'?  I tried doing 'book1\nbook2', which is what it
appears to be in the horde_prefs table after I set the preference
manually.
You need double quotes for the \n to be interpreted as a newline there.
2)  Regardless of which addressbooks I select and the order I put
them in, for any menu that displays addressbooks, the localsql
addressbook is always the default selection.  The addressbooks are in
the right order but the first one is not selected.
Then it's selected as your "default directory" - see the search 
options section of the prefs. This definitely needs to be put in a 
better place - suggestions?
3)  Probably the same issue as #2 but when I invoke the addressbook
from IMP, the order of the addressbooks is correct, but the localsql
entry is always selected.  What I was anticipating is that if a user
selected the directory server entry first, then any app that used the
addressbook would default to using that first as well.
Yes, same reason.
06/02/2005 08:15:07 PM kevin_myer (at) iu13 (dot) org Comment #6 Reply to this comment
In production currently on two sites.  Just three items:



1)  What's the syntax for setting a default preference for 
'addressbooks'?  I tried doing 'book1\nbook2', which is what it 
appears to be in the horde_prefs table after I set the preference 
manually.  But when I go to the preference screen in Turba, both 
addressbooks show as being unselected (although per your note, they do 
show up in browse or search mode).  I think thats good and preserves 
backwards compatibility.



2)  Regardless of which addressbooks I select and the order I put them 
in, for any menu that displays addressbooks, the localsql addressbook 
is always the default selection.  The addressbooks are in the right 
order but the first one is not selected.



3)  Probably the same issue as #2 but when I invoke the addressbook 
from IMP, the order of the addressbooks is correct, but the localsql 
entry is always selected.  What I was anticipating is that if a user 
selected the directory server entry first, then any app that used the 
addressbook would default to using that first as well.
05/24/2005 09:15:24 PM Chuck Hagenbuch State ⇒ Resolved
 
05/24/2005 08:13:27 PM Chuck Hagenbuch Comment #5
State ⇒ Feedback
Reply to this comment
This feature has been committed to CVS. Please test and let me know if 
it's complete/as expected or if anything else needs to be done.



Note that if a user doesn't set this preference, they'll be shown all 
address books, to avoid confusing them by showing them nothing.
05/11/2005 09:17:58 PM kevin_myer (at) iu13 (dot) org Comment #4 Reply to this comment
Sorry - ambigious modifier on the original request.



We want to be able to:



1) sort the order of the addressbook display and,

2) choose which addressbooks to display



Hence "order of and names of available addressbooks".  Item 1 affects 
the order and Item 2 affects which names display.



We definitely do not want users to be able to rename addressbooks.
05/11/2005 06:37:50 PM Chuck Hagenbuch Comment #3 Reply to this comment
Just a quick check what you meant about names - did you want users to 
be able to customize the name they see for each addressbook? I 
understand controlling the order and which, but I'm not sure about 
letting people "rename" them.
04/03/2005 01:26:50 AM kevin_myer (at) iu13 (dot) org Comment #2 Reply to this comment
Found another app that would benefit.  Kronolith has a pref that pulls 
in all contact/sources.  In a setting like ours, it starts to get 
computationally expensive to search all sources for FBurl info.  So 
limiting searches to the preference set in turba would Be A Good Thing.
03/31/2005 01:52:11 AM Chuck Hagenbuch State ⇒ Accepted
 
03/30/2005 10:44:58 PM kevin_myer (at) iu13 (dot) org Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Add turba preference to set which addressbooks to display
Queue ⇒ Turba
State ⇒ New
Reply to this comment
See thread below for reference:

http://lists.horde.org/archives/imp/Week-of-Mon-20050328/041522.html



Add a user preference so that the order of and names of available 
addressbooks can be customized and saved.  This would affect the Turba 
search screen and the IMP contacts screen in the compose window (at 
least thats all I'm aware of currently).

Saved Queries