Summary | empty lines in tooltip information on task list |
Queue | Nag |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | birnbacs (at) gmail (dot) com |
Created | 08/22/2017 (2929 days ago) |
Due | |
Updated | 08/24/2017 (2927 days ago) |
Assigned | |
Resolved | 08/24/2017 (2927 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
commit 0e1d00241f841e40d4b32567121504cb6aa75c5e
Author: Jan Schneider <jan@horde.org>
Date: Thu Aug 24 14:54:38 2017 +0200
Line breaks may consist of CRs too (
Bug #14684).framework/Core/lib/Horde.php | 35 ++++++++++++++++++++++++++---------
framework/Core/package.xml | 4 ++--
2 files changed, 28 insertions(+), 11 deletions(-)
http://github.com/horde/horde/commit/0e1d00241f841e40d4b32567121504cb6aa75c5e
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Nag
Summary ⇒ empty lines in tooltip information on task list
Type ⇒ Bug
State ⇒ Unconfirmed
displaying the task description. If the description has more than one
line, empty lines are shown between adjacent lines. The HTML source
code reveals that there are sequences of "\r","" introduced
between each two lines.
The tooltip is generated in nag/templates/list/_task.html.php, line 57:
echo Horde::linkTooltip($task->view_link->add($params), '',
'', '', '', $task->desc)
. $task_name . '</a>';
The linkTooltip method in line 596 of Horde.php reads:
$attributes['nicetitle'] = Horde_Serialize::serialize(explode("\n",
preg_replace('/<br\s*\/?\s*>/', "\n", $title)), Horde_Serialize::JSON);
It sems that the Serialize method (in JSON mode) introduces the
spurious quoted commas (see above).