Tickets :: [#14525] Fix warnings in Google Maps API calls

6.0.0-beta1

7/4/25

Summary	Fix warnings in Google Maps API calls
Queue	Horde Base
Queue Version	5.2.12
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	arjen+horde (at) de-korte (dot) org
Created	11/30/2016 (3138 days ago)
Due
Updated	12/02/2016 (3136 days ago)
Assigned	12/02/2016 (3136 days ago)
Resolved	12/02/2016 (3136 days ago)
Milestone
Patch	Yes

12/02/2016 08:56:56 PM	Michael Rubinsky	State ⇒ Resolved

12/02/2016 08:56:48 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (master): commit a437a87a89d3e6e25d4b916aaa6d8800848ac790 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 2 15:54:39 2016 -0500 ~~Bug: 14525~~ Remove last vestiges of Yahoo's map service. framework/Core/js/map/horde.js \| 4 ++-- framework/Core/js/map/map.js \| 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/a437a87a89d3e6e25d4b916aaa6d8800848ac790

12/02/2016 08:56:47 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (master): commit a48b603b0547d658a0a1e7ce1447e6a257ca327c Author: arjen+horde (at) de-korte (dot) org <arjen+horde@de-korte.org> Date: Fri Dec 2 15:49:09 2016 -0500 ~~Bug: 14525~~ Fix warnings from Google Maps API. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> framework/Core/js/map/map.js \| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) http://github.com/horde/horde/commit/a48b603b0547d658a0a1e7ce1447e6a257ca327c

12/02/2016 08:44:58 PM	Michael Rubinsky	Comment #3 Assigned to Michael Rubinsky State ⇒ Assigned	Reply to this comment
When using the Google Maps API, three warnings are shown in the console ( NoApiKeys, RetiredVersion and SensorNotRequired). The attached patch fixes these. I'm not entirely sure which version to choose to replace the retired 'v=3.5', both 'v=3' and 'v=3.26' seem to work fine as of today. According to the documentation, requesting a retired version will always return the current "frozen" version. So the current code should be fine. However, Google recommends for basic usage to request the "release" version (v3) so we will go with that. [Show Quoted Text - 9 lines][Hide Quoted Text] The first will probably prevent future warnings about retired versions (as it will always select the latest released version), at the risk that something might break if it is incompatible with existing Horde code. The latter will prevent that, at the 'cost' of quarterly (or half-yearly) updates of the version to prevent this warning from popping up again. Last it also changes 'maps.google.com' to 'maps.googleapis.com' as this seems to be the recommended name now. Thanks!

12/01/2016 10:05:41 PM	arjen+horde (at) de-korte (dot) org	Comment #2	Reply to this comment
It might also be worthwhile to remove the references to the Yahoo Maps API (defunct since September 2011). The Yahoo API key is also still mentioned in the API Keys (<horde>/config/conf.xml).

11/30/2016 10:44:48 AM	arjen+horde (at) de-korte (dot) org	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Fix warnings in Google Maps API calls Queue ⇒ Horde Base Milestone ⇒ Patch ⇒ Yes New Attachment: map.js.diff State ⇒ New	Reply to this comment
When using the Google Maps API, three warnings are shown in the console ( NoApiKeys, RetiredVersion and SensorNotRequired). The attached patch fixes these. I'm not entirely sure which version to choose to replace the retired 'v=3.5', both 'v=3' and 'v=3.26' seem to work fine as of today. The first will probably prevent future warnings about retired versions (as it will always select the latest released version), at the risk that something might break if it is incompatible with existing Horde code. The latter will prevent that, at the 'cost' of quarterly (or half-yearly) updates of the version to prevent this warning from popping up again. Last it also changes 'maps.google.com' to 'maps.googleapis.com' as this seems to be the recommended name now.