6.0.0-beta1
7/18/25

[#14285] Garbage collection /static directory broken
Summary Garbage collection /static directory broken
Queue Horde Framework Packages
Type Bug
State Resolved
Priority 1. Low
Owners
Requester arjen+horde (at) de-korte (dot) org
Created 03/10/2016 (3417 days ago)
Due
Updated 04/08/2016 (3388 days ago)
Assigned
Resolved 04/08/2016 (3388 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
04/08/2016 02:22:50 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit b58b7b5c69fb5f380385531d4d6c5aa6d9de1876
Author: Jan Schneider <jan@horde.org>
Date:   Fri Apr 8 16:22:10 2016 +0200

     GC map files too (Bug #14285).

  framework/Core/lib/Horde/Script/Cache/File.php |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/b58b7b5c69fb5f380385531d4d6c5aa6d9de1876
04/08/2016 02:22:47 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit b020615093684dd2b69a53a0c626be0455c62215
Author: Jan Schneider <jan@horde.org>
Date:   Fri Apr 8 16:21:52 2016 +0200

     Fix logic (Bug #14285).

  framework/Core/lib/Horde/Script/Cache/File.php     |    6 ++++--
  framework/Core/lib/Horde/Themes/Css/Cache/File.php |    6 ++++--
  2 files changed, 8 insertions(+), 4 deletions(-)

http://github.com/horde/horde/commit/b020615093684dd2b69a53a0c626be0455c62215
04/08/2016 02:22:42 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 83f51b3b11eccb0fe34bce9814bef68a8a187782
Author: Jan Schneider <jan@horde.org>
Date:   Fri Apr 8 16:20:58 2016 +0200

     Of course we need to run this in the constructor.

     If we run in the destructor we delete the just created cache file.

     Bug: 14285

  framework/Core/lib/Horde/Script/Cache.php     |    7 -------
  framework/Core/lib/Horde/Themes/Css/Cache.php |    7 -------
  2 files changed, 0 insertions(+), 14 deletions(-)

http://github.com/horde/horde/commit/83f51b3b11eccb0fe34bce9814bef68a8a187782
04/08/2016 02:00:35 PM Jan Schneider State ⇒ Resolved
 
04/08/2016 02:00:04 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 358a9aaa193fd40f2b70955f85089759dc325ac8
Author: Jan Schneider <jan@horde.org>
Date:   Fri Apr 8 15:59:45 2016 +0200

     [jan] Fix running garbage collection on cached CSS and JS files 
(Bug #14285).

  framework/Core/lib/Horde/Script/Cache.php     |   10 ++++++++++
  framework/Core/lib/Horde/Themes/Css/Cache.php |   10 ++++++++++
  framework/Core/package.xml                    |    4 ++--
  3 files changed, 22 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/358a9aaa193fd40f2b70955f85089759dc325ac8
03/10/2016 11:56:57 AM arjen+horde (at) de-korte (dot) org Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Garbage collection /static directory broken
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
I'm not sure if this ever worked, but it looks like garbage collection 
for the /static directory when CSS and Javascript cache is place is 
not working here. Looking at

     horde/framework/Core/lib/Horde/Themes/Css/Cache/File.php
     horde/framework/Core/lib/Horde/Script/Cache/File.php

there should be a 'gc_cachecss' and 'gc_cachejs' file in the /static 
directory respectively to prevent running the GC more than once a day. 
As far as I can see, this file should be created the first time the GC 
runs. However, neither of them is present and the cached theme CSS and 
Javascript files date back many months.

Saved Queries