6.0.0-beta1
7/14/25

[#14188] option "confirm_delete" does not work with dynamic view
Summary option "confirm_delete" does not work with dynamic view
Queue Kronolith
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester pascal.rigaux (at) univ-paris1 (dot) fr
Created 12/11/2015 (3503 days ago)
Due
Updated 12/23/2015 (3491 days ago)
Assigned 12/11/2015 (3503 days ago)
Resolved 12/23/2015 (3491 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
12/23/2015 09:26:07 PM Michael Rubinsky State ⇒ Resolved
 
12/23/2015 09:25:11 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit b0edee78ee37110cf45584b9ae1614cb6a17526d
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Wed Dec 23 16:18:50 2015 -0500

     Bug: 14188  Honor confirm_delete preference in dynamic view.

  kronolith/js/kronolith.js |   27 +++++++++++++++++++++------
  kronolith/lib/Ajax.php    |    3 ++-
  2 files changed, 23 insertions(+), 7 deletions(-)

http://github.com/horde/horde/commit/b0edee78ee37110cf45584b9ae1614cb6a17526d
12/23/2015 09:23:15 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit d9f59a39b9e40e2a1cb30f6ff1e7d7b61e48479c
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Wed Dec 23 16:18:50 2015 -0500

     Bug: 14188  Honor confirm_delete preference in dynamic view.

  kronolith/js/kronolith.js |   27 +++++++++++++++++++++------
  kronolith/lib/Ajax.php    |    3 ++-
  2 files changed, 23 insertions(+), 7 deletions(-)

http://github.com/horde/horde/commit/d9f59a39b9e40e2a1cb30f6ff1e7d7b61e48479c
12/11/2015 03:02:49 PM Michael Rubinsky Comment #4 Reply to this comment
Thanks for the patch, but you are correct. We will go with something a 
little more "complicated" :)


12/11/2015 03:01:14 PM Michael Rubinsky Comment #3
Assigned to Michael Rubinsky
State ⇒ Assigned
Reply to this comment
Confirmed.
12/11/2015 12:18:04 PM pascal (dot) rigaux (at) univ-paris1 (dot) fr Comment #2
New Attachment: 0001-handle-confirm_delete-conf-in-dynamic-view-GLPI-UP1-.patch Download
Reply to this comment
The attached patch fixes the issue but is somewhat ugly:
- it checks wether 'kronolithNoRecurDelete' is displayed or not
- it simulates a click 'kronolithEventDeleteConfirm'

Other solutions are possible, but more complicated...

12/11/2015 12:14:30 PM pascal (dot) rigaux (at) univ-paris1 (dot) fr Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ option "confirm_delete" does not work with dynamic view
Type ⇒ Bug
Reply to this comment
When you click to delete an existing event, you are always prompted 
for confirmation.
"confirm_delete" option is not taken into account.

Saved Queries