6.0.0-beta1
7/4/25

[#14096] Make "Create Keys" button in IMP prefs depend on $conf['pgp']['keylength']
Summary Make "Create Keys" button in IMP prefs depend on $conf['pgp']['keylength']
Queue IMP
Queue Version 6.2.10
Type Enhancement
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester steffen.hau (at) rz (dot) uni-mannheim (dot) de
Created 08/31/2015 (3595 days ago)
Due
Updated 09/21/2015 (3574 days ago)
Assigned
Resolved 09/21/2015 (3574 days ago)
Milestone 6.2.11
Patch Yes

History
09/21/2015 04:27:51 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit f39f9ca14bae00e54c4c505b0124a6262a2323b1
Author: Jan Schneider <jan@horde.org>
Date:   Mon Sep 21 18:18:38 2015 +0200

     Don't show "Create Keys" button if creating PGP keys is disabled 
(steffen.hau@rz.uni-mannheim.de, Request #14096).

  imp/lib/Prefs/Special/PgpPrivateKey.php    |    1 +
  imp/templates/prefs/pgpprivatekey.html.php |    2 ++
  2 files changed, 3 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/f39f9ca14bae00e54c4c505b0124a6262a2323b1
09/21/2015 04:27:47 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit e94bdc8905ce2797c60060ac123a34114ccb8fb2
Author: Jan Schneider <jan@horde.org>
Date:   Mon Sep 21 18:25:08 2015 +0200

     Don't show "Create Keys" button if creating PGP keys is disabled 
(steffen.hau@rz.uni-mannheim.de, Request #14096).

  imp/docs/CHANGES |    2 ++
  imp/package.xml  |    2 ++
  2 files changed, 4 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/e94bdc8905ce2797c60060ac123a34114ccb8fb2
09/21/2015 04:27:45 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
Milestone ⇒ 6.2.11
 
09/21/2015 04:21:35 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 39da3f4fbcb9ed6f41e1ba9ca5a581b7d0004649
Author: Jan Schneider <jan@horde.org>
Date:   Mon Sep 21 18:18:38 2015 +0200

     Don't show "Create Keys" button if creating PGP keys is disabled 
(steffen.hau@rz.uni-mannheim.de, Request #14096).

  imp/lib/Prefs/Special/PgpPrivateKey.php    |    1 +
  imp/templates/prefs/pgpprivatekey.html.php |    2 ++
  2 files changed, 3 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/39da3f4fbcb9ed6f41e1ba9ca5a581b7d0004649
08/31/2015 02:52:01 PM steffen (dot) hau (at) rz (dot) uni-mannheim (dot) de New Attachment: imp_display_create-keys_pref_only_when_keylength_is_greater_then_zero.patch Download
 
08/31/2015 02:50:50 PM steffen (dot) hau (at) rz (dot) uni-mannheim (dot) de Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Make "Create Keys" button in IMP prefs depend on $conf['pgp']['keylength']
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
State ⇒ New
Reply to this comment
We've enabled PGP in our horde Installations, but disabled the 
server-side key generation by setting $conf['pgp']['keylength'] to 0, 
but the button "Create Keys" is still displayed which leads to 
confusion.

The attached small patch makes the visibility of the button dependent 
on $conf['pgp']['keylength'].

Saved Queries