Summary | Calender won't get synched |
Queue | Synchronization |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | Horde Developers (at) , mrubinsk (at) horde (dot) org |
Requester | thomas (at) trethan (dot) net |
Created | 07/24/2014 (3988 days ago) |
Due | |
Updated | 07/28/2014 (3984 days ago) |
Assigned | 07/24/2014 (3988 days ago) |
Resolved | 07/24/2014 (3988 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
block could now be replace by $database to avoid a second call to
normalize().
Agree, that a formalized export API is required, an assoc array
$options might be a good idea.
Remark to the current fix: $this->normalize($databaseURI) in the try
block could now be replace by $database to avoid a second call to
normalize().
State ⇒ Resolved
State ⇒ Feedback
Taken from Jan Schneider
commit 1c92f6de553cd476c79620590e303cc6253fe5dc
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Thu Jul 24 13:39:12 2014 -0400
Bug: 13394Hotfix for dealing with different function signaturesin export API.
.../SyncMl/lib/Horde/SyncMl/Backend/Horde.php | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/1c92f6de553cd476c79620590e303cc6253fe5dc
State ⇒ Assigned
Assigned to
Assigned to Michael Rubinsky
Assigned to Jan Schneider
Priority ⇒ 2. Medium
The SyncML code is assuming all export methods have the same
parameters, which they currently do not. It looks Turba is the only
app that has a $fields parameter.
For H6 we need to formalize the "export" API, probably by just using
an $options array, but we can't change the parameter order now since
it's a BC break with the already released applications.
public function export($uid, $contentType, array $options = array(),
array $fields = null, array $calendars = null)
In SyncMl/Backend/Horde.php in function retrieveEntry() the export
function is called with $fields as 4th parameter, passing the accepted
sync fields to the export function.
In kronolith/lib/Api.php the 4th parameter of the function export() is
$calenders. Therefore the passed fields (which are arrays) get added
to the searched calenders, which will throw an sql exception and won't
export anything.
This change in the export function was made here, but I don't figured
out why or where else this might by used:
https://github.com/horde/horde/commit/1ce32155134bdcb36bc1f63f740b881aec2b6819
Interesting note: I encountered the problem twice now; after it
happened the first time, sync started to work "magically" again some
time later, before I could manage to debug. Now - some time passed -
it happened again. Don't know why it worked in between, no server
upgrades/patches took place...
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Synchronization
Summary ⇒ Calender won't get synched
Type ⇒ Bug
Priority ⇒ 3. High