6.0.0-alpha14
6/24/25

[#13393] Tags of contacts don't get synched back
Summary Tags of contacts don't get synched back
Queue Synchronization
Queue Version Git master
Type Bug
State Resolved
Priority 2. Medium
Owners mrubinsk (at) horde (dot) org
Requester thomas (at) trethan (dot) net
Created 07/24/2014 (3988 days ago)
Due
Updated 07/28/2014 (3984 days ago)
Assigned
Resolved 07/24/2014 (3988 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
07/28/2014 07:26:09 AM thomas (at) trethan (dot) net Comment #6 Reply to this comment
Fix is working.

First I thought that the missing space in the explode function ("," 
instead of ", ") will cause troubles, but it works. Tags get 
concatenated in turba/lib/Object.php in function synchronizeTags() 
with a space. Maybe the tags get trimmed somewhere later or the sync 
client handles this...
07/24/2014 08:18:32 PM Michael Rubinsky Comment #5
Assigned to Michael Rubinsky
State ⇒ Resolved
Reply to this comment
Turba 4.2.1
07/24/2014 08:16:31 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 0d7d3252d31162fd5ce1adc16429047e4fe791d0
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Thu Jul 24 16:12:30 2014 -0400

     Bug: 13393  Fix exporting Tags/Categories in vCard.

  turba/lib/Driver.php |    8 ++++++--
  1 files changed, 6 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/0d7d3252d31162fd5ce1adc16429047e4fe791d0
07/24/2014 08:15:06 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 50b18d67d8398e200e3ba78f1985b2760c4e9189
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Thu Jul 24 16:12:30 2014 -0400

     Bug: 13393  Fix exporting Tags/Categories in vCard.

  turba/lib/Driver.php |    8 ++++++--
  1 files changed, 6 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/50b18d67d8398e200e3ba78f1985b2760c4e9189
07/24/2014 09:34:42 AM thomas (at) trethan (dot) net Comment #2 Reply to this comment
Found out, that Turba only exports fields listet in the backend-map, 
where "__tags" is not listed for a mysql backend (see lib/Driver.php 
function tovCard()). When manually adding "__tags" to $attributes, it 
works. Either need to add "__tags" to the backend-map (question how?) 
or need to respect tags somehow in the tovcard-code.

My quick and dirty solution:
$attributes[] = '__tags';

Found another problem in turba/lib/Driver.php function tovCard(), when 
reading "__tags" and trying to set the vcard-attribute CATEGORIES, 
$val holds the tags as concattenated string (as retrieved by the 
Turba_Tagger in turba/lib/Object.php), but needs to be an array:

$vcard->setAttribute('CATEGORIES', null, array(), true, explode(', ', $val));
07/24/2014 09:27:39 AM thomas (at) trethan (dot) net Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Tags of contacts don't get synched back
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
Wen synching contacts from a Samsung Galaxy S3, contact groups get 
correctly imported as tags in horde. When synching back from Horde, 
tags don't get exported.

Saved Queries