Summary | Tags of contacts don't get synched back |
Queue | Synchronization |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | mrubinsk (at) horde (dot) org |
Requester | thomas (at) trethan (dot) net |
Created | 07/24/2014 (3988 days ago) |
Due | |
Updated | 07/28/2014 (3984 days ago) |
Assigned | |
Resolved | 07/24/2014 (3988 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
First I thought that the missing space in the explode function (","
instead of ", ") will cause troubles, but it works. Tags get
concatenated in turba/lib/Object.php in function synchronizeTags()
with a space. Maybe the tags get trimmed somewhere later or the sync
client handles this...
Assigned to Michael Rubinsky
State ⇒ Resolved
commit 0d7d3252d31162fd5ce1adc16429047e4fe791d0
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Thu Jul 24 16:12:30 2014 -0400
Bug: 13393Fix exporting Tags/Categories in vCard.turba/lib/Driver.php | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/0d7d3252d31162fd5ce1adc16429047e4fe791d0
commit 50b18d67d8398e200e3ba78f1985b2760c4e9189
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Thu Jul 24 16:12:30 2014 -0400
Bug: 13393Fix exporting Tags/Categories in vCard.turba/lib/Driver.php | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/50b18d67d8398e200e3ba78f1985b2760c4e9189
where "__tags" is not listed for a mysql backend (see lib/Driver.php
function tovCard()). When manually adding "__tags" to $attributes, it
works. Either need to add "__tags" to the backend-map (question how?)
or need to respect tags somehow in the tovcard-code.
My quick and dirty solution:
$attributes[] = '__tags';
Found another problem in turba/lib/Driver.php function tovCard(), when
reading "__tags" and trying to set the vcard-attribute CATEGORIES,
$val holds the tags as concattenated string (as retrieved by the
Turba_Tagger in turba/lib/Object.php), but needs to be an array:
$vcard->setAttribute('CATEGORIES', null, array(), true, explode(', ', $val));
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Tags of contacts don't get synched back
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
correctly imported as tags in horde. When synching back from Horde,
tags don't get exported.