Tickets :: [#13370] minicalendar calendarweek selection doesn't work anymore since update to horde 5.2.0

6.0.0-beta1

7/14/25

Summary	minicalendar calendarweek selection doesn't work anymore since update to horde 5.2.0
Queue	Kronolith
Queue Version	FRAMEWORK_5_2
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	chhaas-ml (at) ukbw (dot) de
Created	07/15/2014 (4017 days ago)
Due
Updated	07/24/2014 (4008 days ago)
Assigned
Resolved	07/20/2014 (4012 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

07/24/2014 01:58:10 PM	chhaas-ml (at) ukbw (dot) de	Comment #7	Reply to this comment
thank you, this saved my day! I applied this fix also to kronolith 4.20 (stable) and it worked there as well.

07/24/2014 01:55:41 PM	chhaas-ml (at) ukbw (dot) de	Comment #6	Reply to this comment
[Show Quoted Text - 14 lines][Hide Quoted Text] Changes have been made in Git (FRAMEWORK_5_2): commit 19deacb24935c93e69bd33adad32f3cfbec6e2b4 Author: Jasper Olbrich <Jasper.Olbrich@students.uni-marburg.de> Date: Sun Jul 20 15:04:46 2014 -0400 ~~Bug: 13370~~ Fix detecting td elements and fix catching minical clicks. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> kronolith/js/kronolith.js \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/19deacb24935c93e69bd33adad32f3cfbec6e2b4

07/20/2014 07:11:03 PM	Michael Rubinsky	Comment #5 Assigned to Michael Rubinsky State ⇒ Resolved Priority ⇒ 1. Low	Reply to this comment
Kronolith 4.2.1

07/20/2014 07:08:24 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 19deacb24935c93e69bd33adad32f3cfbec6e2b4 Author: Jasper Olbrich <Jasper.Olbrich@students.uni-marburg.de> Date: Sun Jul 20 15:04:46 2014 -0400 ~~Bug: 13370~~ Fix detecting td elements and fix catching minical clicks. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> kronolith/js/kronolith.js \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/19deacb24935c93e69bd33adad32f3cfbec6e2b4

07/20/2014 07:06:33 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit 4e70bbc2fcff325d44f54932fc9d378e4d2c35ef Author: Jasper Olbrich <Jasper.Olbrich@students.uni-marburg.de> Date: Sun Jul 20 15:04:46 2014 -0400 ~~Bug: 13370~~ Fix detecting td elements and fix catching minical clicks. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> kronolith/js/kronolith.js \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/4e70bbc2fcff325d44f54932fc9d378e4d2c35ef

07/17/2014 09:13:01 AM	Jasper (dot) Olbrich (at) students (dot) uni-marburg (dot) de	Comment #2	Reply to this comment
I can confirm this behavior and was able to fix this by adding .toLowerCase() to the tag name (which seems to be returned in upper case, so it can never match 'td': if (tmp.tagName.toLowerCase() != 'td') { tmp = tmp.up('td'); } According to this https://developer.mozilla.org/en-US/docs/Web/API/Element.tagName the tag name is returned "as is" for XHTML and all uppercase for HTML, so the .toLowerCase()-method is probably bettern than checking for !='TD'?

07/15/2014 10:58:54 AM	chhaas-ml (at) ukbw (dot) de	Comment #1 Priority ⇒ 3. High Type ⇒ Bug Summary ⇒ minicalendar calendarweek selection doesn't work anymore since update to horde 5.2.0 Queue ⇒ Kronolith Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
since the update from horde 5.1.4 to 5.2.0 the selection of calendar weeks in the minicalendar seems to be no more working. This is a drops - at least for me - the usabilitiy in kronolith! I ran /usr/bin/horde-clear-cache with no effect on this misbehaviour. Maybe this is a sideeffect of solving ~~bug #13327~~? The releasenotes of 5.2.0 are pointing in this direction ... Christoph.