Tickets :: [#13308] wrong task list after changes in smart list

6.0.0-beta1

7/14/25

Summary	wrong task list after changes in smart list
Queue	Nag
Queue Version	4.2.0beta2
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	samuel.wolf (at) wolf-maschinenbau (dot) de
Created	07/01/2014 (4031 days ago)
Due
Updated	07/01/2014 (4031 days ago)
Assigned	07/01/2014 (4031 days ago)
Resolved	07/01/2014 (4031 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

07/01/2014 10:25:06 PM	samuel (dot) wolf (at) wolf-maschinenbau (dot) de	Comment #15	Reply to this comment
[Show Quoted Text - 15 lines][Hide Quoted Text] Changes have been made in Git (FRAMEWORK_5_2): commit 9bf765fab6b18b4c051c047f2f63d62e5fd6c7ee Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 13:52:30 2014 -0400 Proper fix for ~~Bug: 13308~~ nag/app/controllers/SaveTask.php \| 3 ++- nag/task.php \| 3 +++ nag/templates/list.html.php \| 3 +-- nag/templates/list/_task.html.php \| 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/9bf765fab6b18b4c051c047f2f63d62e5fd6c7ee That's it, thanks mike!

07/01/2014 06:38:59 PM	Michael Rubinsky	State ⇒ Resolved

07/01/2014 06:35:27 PM	Git Commit	Comment #14	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 9bf765fab6b18b4c051c047f2f63d62e5fd6c7ee Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 13:52:30 2014 -0400 Proper fix for ~~Bug: 13308~~ nag/app/controllers/SaveTask.php \| 3 ++- nag/task.php \| 3 +++ nag/templates/list.html.php \| 3 +-- nag/templates/list/_task.html.php \| 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/9bf765fab6b18b4c051c047f2f63d62e5fd6c7ee

07/01/2014 06:35:24 PM	Git Commit	Comment #13	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit c49b3f7229ac849c0480bed87b57be356da29208 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 13:48:30 2014 -0400 Revert "~~Bug: 13308~~ Fix returning to previously selected tab after task is saved." This reverts commit 6343acc8221a9ba5f26ca55d302c1cc074b072e2. nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 1 - nag/lib/View/List.php \| 1 - nag/task.php \| 3 --- nag/templates/list/_task.html.php \| 2 +- 5 files changed, 2 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/c49b3f7229ac849c0480bed87b57be356da29208

07/01/2014 06:34:13 PM	Git Commit	Comment #12	Reply to this comment
Changes have been made in Git (master): commit eaecfe4c83a8d81d7a294e40f15aaf07fc2cb1c6 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 14:32:14 2014 -0400 Fix using 'Return to Search' links for both SmartLists and normal searches. Related to ~~Bug: 13308~~ nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 2 ++ nag/lib/View/List.php \| 4 ++++ nag/task.php \| 7 +++++++ nag/templates/list/_task.html.php \| 11 +++++++++-- nag/templates/view/task.inc \| 3 ++- 6 files changed, 25 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/eaecfe4c83a8d81d7a294e40f15aaf07fc2cb1c6

07/01/2014 06:34:07 PM	Git Commit	Comment #11	Reply to this comment
Changes have been made in Git (master): commit 287f44f030d59a80358f4f6201599bbebc14da0d Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 13:52:30 2014 -0400 Proper fix for ~~Bug: 13308~~ nag/app/controllers/SaveTask.php \| 3 ++- nag/task.php \| 3 +++ nag/templates/list.html.php \| 3 +-- nag/templates/list/_task.html.php \| 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/287f44f030d59a80358f4f6201599bbebc14da0d

07/01/2014 06:34:02 PM	Git Commit	Comment #10	Reply to this comment
Changes have been made in Git (master): commit 2c02aca53176cf96ce569ea561321f4285619b92 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 13:48:30 2014 -0400 Revert "~~Bug: 13308~~ Fix returning to previously selected tab after task is saved." This reverts commit 6343acc8221a9ba5f26ca55d302c1cc074b072e2. nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 1 - nag/lib/View/List.php \| 1 - nag/task.php \| 3 --- nag/templates/list/_task.html.php \| 2 +- 5 files changed, 2 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/2c02aca53176cf96ce569ea561321f4285619b92

07/01/2014 05:16:38 PM	Michael Rubinsky	Comment #9 State ⇒ Assigned	Reply to this comment
Grr. In my small test setup, the 'Completed' and the SmartLists both contained the same results so I didn't notice that. You are correct, the tab is selected, but the data is wrong.

07/01/2014 05:11:50 PM	samuel (dot) wolf (at) wolf-maschinenbau (dot) de	Comment #8	Reply to this comment
Is the problem that both "selected"? No, this is a display issue only and was already fixed by: https://github.com/horde/horde/commit/269f39b72196b781be0814b7dc08b9f418be38c3 Confirm the selected issue is gone now. After edit and save a task of a smart list this tab is selected, but it show the result of the "Completed tasks". Maybe some other commits I missing, better to wait for the next release if it work in your setup ;-)

07/01/2014 04:54:16 PM	Michael Rubinsky	Comment #7	Reply to this comment
Is the problem that both "selected"? No, this is a display issue only and was already fixed by: https://github.com/horde/horde/commit/269f39b72196b781be0814b7dc08b9f418be38c3

07/01/2014 04:53:14 PM	Michael Rubinsky	Comment #6	Reply to this comment
This was a separate issue that caused a fatal, "share not found" error when only one tasklist exists and at least one smartlist exists. It's possible this causes you to get thrown back to list.php though.

07/01/2014 04:49:02 PM	samuel (dot) wolf (at) wolf-maschinenbau (dot) de	Comment #5 New Attachment: nag.png	Reply to this comment
Is the problem that both "selected"?

07/01/2014 04:41:48 PM	samuel (dot) wolf (at) wolf-maschinenbau (dot) de	Comment #4	Reply to this comment
[Show Quoted Text - 16 lines][Hide Quoted Text] Changes have been made in Git (FRAMEWORK_5_2): commit 174e5dcaa784c8d1c55c2d7d7a73071a432d6b41 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 12:08:06 2014 -0400 ~~Bug: 13308~~ Fix returning to previously selected tab after task is saved. nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 1 + nag/lib/View/List.php \| 1 + nag/task.php \| 3 +++ nag/templates/list/_task.html.php \| 2 +- 5 files changed, 7 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/174e5dcaa784c8d1c55c2d7d7a73071a432d6b41 Same result with this changes, I also add this commit: https://github.com/horde/horde/commit/bb73ed495fdf99c2b3678b091e25b6cbae5cbf9e

07/01/2014 04:11:25 PM	Michael Rubinsky	Assigned to Michael Rubinsky State ⇒ Resolved

07/01/2014 04:10:39 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 174e5dcaa784c8d1c55c2d7d7a73071a432d6b41 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 12:08:06 2014 -0400 ~~Bug: 13308~~ Fix returning to previously selected tab after task is saved. nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 1 + nag/lib/View/List.php \| 1 + nag/task.php \| 3 +++ nag/templates/list/_task.html.php \| 2 +- 5 files changed, 7 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/174e5dcaa784c8d1c55c2d7d7a73071a432d6b41

07/01/2014 04:09:17 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit 6343acc8221a9ba5f26ca55d302c1cc074b072e2 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Jul 1 12:08:06 2014 -0400 ~~Bug: 13308~~ Fix returning to previously selected tab after task is saved. nag/app/controllers/SaveTask.php \| 2 +- nag/lib/Form/Task.php \| 1 + nag/lib/View/List.php \| 1 + nag/task.php \| 3 +++ nag/templates/list/_task.html.php \| 2 +- 5 files changed, 7 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/6343acc8221a9ba5f26ca55d302c1cc074b072e2

07/01/2014 10:51:59 AM	samuel (dot) wolf (at) wolf-maschinenbau (dot) de	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed Patch ⇒ No Milestone ⇒ Summary ⇒ wrong task list after changes in smart list Type ⇒ Bug Queue ⇒ Nag	Reply to this comment
Open a saved smart list and edit a task. After saving the changes/task the browser returns to the "Completed tasks" list and not to the smart list again.