Tickets :: [#13297] Deactivating script has no effect

6.0.0-beta1

7/18/25

Summary	Deactivating script has no effect
Queue	Ingo
Queue Version	3.2.0RC1
Type	Bug
State	Resolved
Priority	1. Low
Owners	slusarz (at) horde (dot) org
Requester	kd (at) tu-cottbus (dot) de
Created	06/27/2014 (4039 days ago)
Due
Updated	07/01/2014 (4035 days ago)
Assigned
Resolved	06/30/2014 (4036 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

07/01/2014 09:09:20 AM	Git Commit	Comment #8	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit a81a75558d4029311f1660a8624458c8897157c8 Author: Jan Schneider <jan@horde.org> Date: Tue Jul 1 10:59:45 2014 +0200 Need to set script inactive before removing it (~~Bug #13297~~). ingo/lib/Transport/Timsieved.php \| 1 + 1 files changed, 1 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/a81a75558d4029311f1660a8624458c8897157c8

07/01/2014 09:09:18 AM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit cd345dfed6e3ba64fd2cfa25672d7c10161f79bf Author: Jan Schneider <jan@horde.org> Date: Tue Jul 1 10:44:37 2014 +0200 This is how we signal transport drivers scripts to deactivate (~~Bug #13297~~). ingo/lib/Script/Util.php \| 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/cd345dfed6e3ba64fd2cfa25672d7c10161f79bf

07/01/2014 09:00:13 AM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (master): commit afce2fb0d5b3b3cf7a0a5b5537e8b6e0a53e96a8 Author: Jan Schneider <jan@horde.org> Date: Tue Jul 1 10:59:45 2014 +0200 Need to set script inactive before removing it (~~Bug #13297~~). ingo/lib/Transport/Timsieved.php \| 1 + 1 files changed, 1 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/afce2fb0d5b3b3cf7a0a5b5537e8b6e0a53e96a8

07/01/2014 08:45:02 AM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (master): commit 2681e2566603126c8aafc9c78d19faace1f7e40c Author: Jan Schneider <jan@horde.org> Date: Tue Jul 1 10:44:37 2014 +0200 This is how we signal transport drivers scripts to deactivate (~~Bug #13297~~). ingo/lib/Script/Util.php \| 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/2681e2566603126c8aafc9c78d19faace1f7e40c

07/01/2014 07:59:25 AM	kd (at) tu-cottbus (dot) de	Comment #4	Reply to this comment
[Show Quoted Text - 14 lines][Hide Quoted Text] Changes have been made in Git (master): commit 394efc92faa3e119918cba09d7f9d8861b0e1ef6 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Jun 30 13:55:38 2014 -0600 [mms] Fix regression in deactivating scripts (~~Bug #13297~~). ingo/docs/CHANGES \| 6 ++++++ ingo/lib/Basic/Script.php \| 11 ++--------- ingo/package.xml \| 16 +--------------- 3 files changed, 9 insertions(+), 24 deletions(-) http://github.com/horde/horde/commit/394efc92faa3e119918cba09d7f9d8861b0e1ef6 This is not enough. The error message is gone, but the script is not deactivated (at least, if transport is 'timsieved'). The activate method in Script/Util.php does not use the $deactivate parameter, probably something like if ($deactivate) { $script['script'] = ''; } must be added.

06/30/2014 07:58:13 PM	Michael Slusarz	Assigned to Michael Slusarz State ⇒ Resolved

06/30/2014 07:57:53 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit 394efc92faa3e119918cba09d7f9d8861b0e1ef6 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Jun 30 13:55:38 2014 -0600 [mms] Fix regression in deactivating scripts (~~Bug #13297~~). ingo/docs/CHANGES \| 6 ++++++ ingo/lib/Basic/Script.php \| 11 ++--------- ingo/package.xml \| 16 +--------------- 3 files changed, 9 insertions(+), 24 deletions(-) http://github.com/horde/horde/commit/394efc92faa3e119918cba09d7f9d8861b0e1ef6

06/30/2014 07:56:30 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 555edd707b71d215f513566e4afd8662b1a65152 Author: Michael M Slusarz <slusarz@horde.org> Date: Mon Jun 30 13:55:38 2014 -0600 [mms] Fix regression in deactivating scripts (~~Bug #13297~~). ingo/docs/CHANGES \| 1 + ingo/lib/Basic/Script.php \| 11 ++--------- ingo/package.xml \| 4 ++-- 3 files changed, 5 insertions(+), 11 deletions(-) http://github.com/horde/horde/commit/555edd707b71d215f513566e4afd8662b1a65152

06/27/2014 07:39:34 AM	kd (at) tu-cottbus (dot) de	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Deactivating script has no effect Queue ⇒ Ingo Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
If transport ist set to sieve, deactivating the script does not work. In the horde logs: HORDE [ingo] PHP ERROR: Invalid argument supplied for foreach() [pid 1381 on line 38 of "/var/www/html/webmail/ingo/lib/Script/Util.php"]