Summary | Fix up broken Kolab backend |
Queue | Mnemo |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 06/18/2014 (4044 days ago) |
Due | |
Updated | 07/01/2014 (4031 days ago) |
Assigned | 06/27/2014 (4035 days ago) |
Resolved | 06/30/2014 (4032 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
commit 22fa2e2d00759976c3f8e12189398fca3dc4778d
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Thu Jun 19 16:12:29 2014 +0200
Fix up broken add/modify operation in Kolab driver
Signed-off-by: Jan Schneider <jan@horde.org>
Bug: 13269mnemo/lib/Driver/Kolab.php | 21 ++++++++++++++-------
1 files changed, 14 insertions(+), 7 deletions(-)
http://github.com/horde/horde/commit/22fa2e2d00759976c3f8e12189398fca3dc4778d
commit 0f35e1eb63139ec862ad48fb92b69f3eb97ea71d
Author: Jan Schneider <jan@horde.org>
Date: Mon Jun 30 17:54:56 2014 +0200
Revert "Actually return object hash and UIDs (
Bug #13269)."This reverts commit 395502df660d3ce48d6de5742ddcea0f8bb70f84.
mnemo/lib/Driver/Kolab.php | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/0f35e1eb63139ec862ad48fb92b69f3eb97ea71d
commit 7dfcba30293aaed2b4afa5ba1ac29b0fdf3d373b
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Thu Jun 19 16:12:29 2014 +0200
Fix up broken add/modify operation in Kolab driver
Signed-off-by: Jan Schneider <jan@horde.org>
Bug: 13269mnemo/lib/Driver/Kolab.php | 21 ++++++++++++++-------
1 files changed, 14 insertions(+), 7 deletions(-)
http://github.com/horde/horde/commit/7dfcba30293aaed2b4afa5ba1ac29b0fdf3d373b
commit ed05c756e0c320c17356370bb4f25ceb50cd750b
Author: Jan Schneider <jan@horde.org>
Date: Mon Jun 30 17:54:56 2014 +0200
Revert "Actually return object hash and UIDs (
Bug #13269)."This reverts commit 395502df660d3ce48d6de5742ddcea0f8bb70f84.
mnemo/lib/Driver/Kolab.php | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/ed05c756e0c320c17356370bb4f25ceb50cd750b
State ⇒ Assigned
the API contract of Kolab_Storage:
modify() return the (IMAP) backend uid of the object in question: Wild
guess: This change will break ActiveSync for Kolab + notes.
State ⇒ Feedback
the API contract of Kolab_Storage:
create() and modify() might return the uid of the Kolab object *or*
true if the used backend does not support it.
IMHO it's better to use my original implementation of this fix.
That would also give proper credits in the git commit history...
State ⇒ Resolved
commit b4bab6ae5c2eb841b47105c32687f5d34654a02c
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 20 15:20:27 2014 +0200
[jan] Fix exporting tags to CSV (Thomas Jarosch
<thomas.jarosch@intra2net.com>,
Bug #13269).mnemo/docs/CHANGES | 2 ++
mnemo/package.xml | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/b4bab6ae5c2eb841b47105c32687f5d34654a02c
commit 1e937e69616d856e94d068106c43f66f965ef3bc
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 20 15:19:42 2014 +0200
[jan] Fix adding and editing notes with Kolab backend (
Bug #13269).mnemo/docs/CHANGES | 1 +
mnemo/package.xml | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/1e937e69616d856e94d068106c43f66f965ef3bc
commit 0818eb9fa2b19757b8efc9c3caba5251b0626d1f
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 20 14:51:09 2014 +0200
Actually return object hash and UIDs (
Bug #13269).mnemo/lib/Driver/Kolab.php | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/0818eb9fa2b19757b8efc9c3caba5251b0626d1f
commit 395502df660d3ce48d6de5742ddcea0f8bb70f84
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 20 14:51:09 2014 +0200
Actually return object hash and UIDs (
Bug #13269).mnemo/lib/Driver/Kolab.php | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/395502df660d3ce48d6de5742ddcea0f8bb70f84
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Fix up broken Kolab backend
Queue ⇒ Mnemo
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Fix-up-broken-add-modify-operation-in-Kolab-driver.patch
State ⇒ Unconfirmed
the Kolab backend in "master" and FRAMEWORK_5_2 is currently broken:
"Add" and "modify" does not work.
Attached patch fixes the issue.
Cheers,
Thomas