6.0.0-beta1
7/14/25

[#13269] Fix up broken Kolab backend
Summary Fix up broken Kolab backend
Queue Mnemo
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 06/18/2014 (4044 days ago)
Due
Updated 07/01/2014 (4031 days ago)
Assigned 06/27/2014 (4035 days ago)
Resolved 06/30/2014 (4032 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
07/01/2014 07:13:59 AM Thomas Jarosch Comment #13 Reply to this comment
Thanks Jan!

06/30/2014 04:03:49 PM Git Commit Comment #12 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 22fa2e2d00759976c3f8e12189398fca3dc4778d
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date:   Thu Jun 19 16:12:29 2014 +0200

     Fix up broken add/modify operation in Kolab driver

     Signed-off-by: Jan Schneider <jan@horde.org>
     Bug: 13269

  mnemo/lib/Driver/Kolab.php |   21 ++++++++++++++-------
  1 files changed, 14 insertions(+), 7 deletions(-)

http://github.com/horde/horde/commit/22fa2e2d00759976c3f8e12189398fca3dc4778d
06/30/2014 04:03:46 PM Git Commit Comment #11 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 0f35e1eb63139ec862ad48fb92b69f3eb97ea71d
Author: Jan Schneider <jan@horde.org>
Date:   Mon Jun 30 17:54:56 2014 +0200

     Revert "Actually return object hash and UIDs (Bug #13269)."

     This reverts commit 395502df660d3ce48d6de5742ddcea0f8bb70f84.

  mnemo/lib/Driver/Kolab.php |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

http://github.com/horde/horde/commit/0f35e1eb63139ec862ad48fb92b69f3eb97ea71d
06/30/2014 04:00:38 PM Jan Schneider State ⇒ Resolved
 
06/30/2014 03:56:54 PM Git Commit Comment #10 Reply to this comment
Changes have been made in Git (master):

commit 7dfcba30293aaed2b4afa5ba1ac29b0fdf3d373b
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date:   Thu Jun 19 16:12:29 2014 +0200

     Fix up broken add/modify operation in Kolab driver

     Signed-off-by: Jan Schneider <jan@horde.org>
     Bug: 13269

  mnemo/lib/Driver/Kolab.php |   21 ++++++++++++++-------
  1 files changed, 14 insertions(+), 7 deletions(-)

http://github.com/horde/horde/commit/7dfcba30293aaed2b4afa5ba1ac29b0fdf3d373b
06/30/2014 03:56:51 PM Git Commit Comment #9 Reply to this comment
Changes have been made in Git (master):

commit ed05c756e0c320c17356370bb4f25ceb50cd750b
Author: Jan Schneider <jan@horde.org>
Date:   Mon Jun 30 17:54:56 2014 +0200

     Revert "Actually return object hash and UIDs (Bug #13269)."

     This reverts commit 395502df660d3ce48d6de5742ddcea0f8bb70f84.

  mnemo/lib/Driver/Kolab.php |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

http://github.com/horde/horde/commit/ed05c756e0c320c17356370bb4f25ceb50cd750b
06/27/2014 01:22:04 PM Thomas Jarosch Comment #8
State ⇒ Assigned
Reply to this comment
Re-opening so we don't forget to fix the API breakage.

06/20/2014 01:56:37 PM Thomas Jarosch Comment #7 Reply to this comment
The way the code was changed from my original implementation breaks
the API contract of Kolab_Storage:
thinking about it some more, the "fix" was totally bogus: create() and 
modify() return the (IMAP) backend uid of the object in question: Wild 
guess: This change will break ActiveSync for Kolab + notes.

06/20/2014 01:42:33 PM Thomas Jarosch Comment #6
State ⇒ Feedback
Reply to this comment
The way the code was changed from my original implementation breaks
the API contract of Kolab_Storage:

create() and modify() might return the uid of the Kolab object *or* 
true if the used backend does not support it.

IMHO it's better to use my original implementation of this fix.
That would also give proper credits in the git commit history...

06/20/2014 01:22:43 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
 
06/20/2014 01:22:23 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit b4bab6ae5c2eb841b47105c32687f5d34654a02c
Author: Jan Schneider <jan@horde.org>
Date:   Fri Jun 20 15:20:27 2014 +0200

     [jan] Fix exporting tags to CSV (Thomas Jarosch 
<thomas.jarosch@intra2net.com>, Bug #13269).

  mnemo/docs/CHANGES |    2 ++
  mnemo/package.xml  |    2 ++
  2 files changed, 4 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/b4bab6ae5c2eb841b47105c32687f5d34654a02c
06/20/2014 01:22:19 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 1e937e69616d856e94d068106c43f66f965ef3bc
Author: Jan Schneider <jan@horde.org>
Date:   Fri Jun 20 15:19:42 2014 +0200

     [jan] Fix adding and editing notes with Kolab backend (Bug #13269).

  mnemo/docs/CHANGES |    1 +
  mnemo/package.xml  |    4 ++--
  2 files changed, 3 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/1e937e69616d856e94d068106c43f66f965ef3bc
06/20/2014 01:22:16 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 0818eb9fa2b19757b8efc9c3caba5251b0626d1f
Author: Jan Schneider <jan@horde.org>
Date:   Fri Jun 20 14:51:09 2014 +0200

     Actually return object hash and UIDs (Bug #13269).

  mnemo/lib/Driver/Kolab.php |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

http://github.com/horde/horde/commit/0818eb9fa2b19757b8efc9c3caba5251b0626d1f
06/20/2014 01:15:41 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 395502df660d3ce48d6de5742ddcea0f8bb70f84
Author: Jan Schneider <jan@horde.org>
Date:   Fri Jun 20 14:51:09 2014 +0200

     Actually return object hash and UIDs (Bug #13269).

  mnemo/lib/Driver/Kolab.php |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

http://github.com/horde/horde/commit/395502df660d3ce48d6de5742ddcea0f8bb70f84
06/18/2014 02:20:36 PM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Fix up broken Kolab backend
Queue ⇒ Mnemo
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Fix-up-broken-add-modify-operation-in-Kolab-driver.patch Download
State ⇒ Unconfirmed
Reply to this comment
Hi,

the Kolab backend in "master" and FRAMEWORK_5_2 is currently broken:
"Add" and "modify" does not work.

Attached patch fixes the issue.

Cheers,
Thomas

Saved Queries