| Summary | EAS: return success for Settings:DeviceInformation request |
| Queue | Synchronization |
| Queue Version | Git master |
| Type | Enhancement |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | hannes.brunssen (at) ewetel (dot) de |
| Created | 05/18/2014 (4078 days ago) |
| Due | |
| Updated | 05/19/2014 (4077 days ago) |
| Assigned | |
| Resolved | 05/19/2014 (4077 days ago) |
| Milestone | |
| Patch | No |
State ⇒ Resolved
commit 83f572b4a298de00d663f4cdd4b6952ba03124b8
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon May 19 11:02:29 2014 -0400
Bug: 13191Fix status return for SETTINGS_DEVICEINFORMATION requests.Device information is stored in the device object, not via the driver.
.../lib/Horde/ActiveSync/Request/Settings.php | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
http://github.com/horde/horde/commit/83f572b4a298de00d663f4cdd4b6952ba03124b8
New Attachment: eas-lg-d802.log
DeviceInformation is 0.
In Horde_ActiveSync_Request_Settings the DeviceInformation is only
passed to the device object (line 220), it's not stored in
$request['set'].
Horde_Core_ActiveSync_Driver::setSettings only handles OOF settings,
it returns an empty array for DeviceInformation, which is stored in
$result['set'] (line 250).
In line 276 $result['set']['deviceinformation'] does not exist and the
returned status is 0.
State ⇒ Feedback
already return STATUS_SUCCESS, unless there is an error.
Also, please attach a log of the failing request.
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ EAS: return success for Settings:DeviceInformation request
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ No
State ⇒ New
the returned status of setting the deviceinformation is currently
always 0. After changing this to SUCCESS the setup works.
I don't known the implications of this change, perhaps some clients
would try to request the deviceinformation later. But they are already
stored, you could even return them.