6.0.0-beta1
7/9/25

[#13110] not all motd files are shown on login page
Summary not all motd files are shown on login page
Queue Horde Base
Queue Version FRAMEWORK_5_1
Type Bug
State Not A Bug
Priority 1. Low
Owners
Requester maciej.uhlig (at) us (dot) edu (dot) pl
Created 04/12/2014 (4106 days ago)
Due 04/13/2014 (4105 days ago)
Updated 04/12/2014 (4106 days ago)
Assigned
Resolved 04/12/2014 (4106 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
04/12/2014 08:06:47 PM maciej (dot) uhlig (at) us (dot) edu (dot) pl Comment #3 Reply to this comment
So motd files should be treated differently than other config files. 
Why use ./motd.d _directory_ which can have many files when you are 
able to show only one file on login page? More than one motd file 
would be extremely comfortable (IMHO).

04/12/2014 04:35:34 PM Michael Rubinsky Comment #2
State ⇒ Not A Bug
Priority ⇒ 1. Low
Reply to this comment
The *.local files are designed to provide a way to overwrite/alter 
configuration values not provide multiple copies of those values.
04/12/2014 12:26:21 PM maciej (dot) uhlig (at) us (dot) edu (dot) pl Comment #1
Priority ⇒ 3. High
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Horde Base
Due ⇒ 04/13/2014
Summary ⇒ not all motd files are shown on login page
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
Imagine you've prepared, besides motd.php, motd.local.php and some 
motd.d/* files. Only last of these local files is shown on login page 
due to a flaw in loadConfiguration() of Horde.php. Namely, line 357:

$output = self::endBuffer();

inside while loop overwrites $output at every iteration. So, the 
output contains last file content only.

The solution woul be to add line:

$output = '';

befole while loop (line 349) and change line 357 to:

$output = $output . self::endBuffer();

After this fix all the motd files content is shown as intended.

Of course an additional effect of this flaw is inability of using more 
than one of other configuration files, however I haven't tested it 
becaues it looks like obvious behaviour.

Saved Queries