Tickets :: [#13044] Turba minisearch block response is broken when contact is not found

6.0.0-beta1

7/15/25

Summary	Turba minisearch block response is broken when contact is not found
Queue	Turba
Queue Version	Git master
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org
Requester	lfbm.andamentos (at) gmail (dot) com
Created	03/13/2014 (4142 days ago)
Due
Updated	03/17/2014 (4138 days ago)
Assigned
Resolved	03/17/2014 (4138 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

03/17/2014 12:30:39 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_1): commit 6774485f97c05fdfdecec90d5c4b998fca5f3aa6 Author: Jan Schneider <jan@horde.org> Date: Mon Mar 17 13:30:24 2014 +0100 [jan] Fix portal serach block response when no contacts have been found (dulinux <lfbm.andamentos@gmail.com>, ~~Bug #13044~~). turba/docs/CHANGES \| 2 ++ turba/package.xml \| 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/6774485f97c05fdfdecec90d5c4b998fca5f3aa6

03/17/2014 12:30:36 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_1): commit 3f607b2595b97ec15686cfe64f706b48fa1019d0 Author: dulinux <lfbm.andamentos@gmail.com> Date: Wed Mar 12 23:31:02 2014 -0300 Fix broken minisearch block response when no contacts have been found. Signed-off-by: Jan Schneider <jan@horde.org> ~~Bug: 13044~~ turba/lib/Ajax/Application/Handler/Minisearch.php \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/3f607b2595b97ec15686cfe64f706b48fa1019d0

03/17/2014 12:27:31 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Resolved

03/17/2014 12:21:14 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit 0bda1e1e3e13a9cf6d62f4febe06cfbd6f29af40 Author: dulinux <lfbm.andamentos@gmail.com> Date: Wed Mar 12 23:31:02 2014 -0300 Fix broken minisearch block response when no contacts have been found. Signed-off-by: Jan Schneider <jan@horde.org> ~~Bug: 13044~~ turba/lib/Ajax/Application/Handler/Minisearch.php \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/0bda1e1e3e13a9cf6d62f4febe06cfbd6f29af40

03/13/2014 02:38:27 AM	lfbm (dot) andamentos (at) gmail (dot) com	Comment #1 Priority ⇒ 2. Medium New Attachment: 0001-Fix-broken-minisearch-block-response-when-no-contact.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Turba Summary ⇒ Turba minisearch block response is broken when contact is not found Type ⇒ Bug State ⇒ Unconfirmed	Reply to this comment
If you type a contact in the minisearch field that is not found in your address books, the minisearch() method will return an empty variable instead of the expected $ob->html = _("No contacts found"). Seems like the code is missing a "!" before the is_null check in order to populate the correct message into $ob->html in the last elseif block. Working Patch is attached.