| Summary | Same timezone exported multiple times in iCal format/subscription |
| Queue | Horde Framework Packages |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | sberthelot (at) emisfr (dot) com |
| Created | 2/21/14 (4431 days ago) |
| Due | |
| Updated | 5/14/14 (4349 days ago) |
| Assigned | 3/21/14 (4403 days ago) |
| Resolved | 5/14/14 (4349 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | Horde_Icalendar 2.0.8 |
| Patch | Yes |
Milestone ⇒ Horde_Icalendar 2.0.8
commit d6fd510312c5ecb20eb760cfb3da93ea94cea6f1
Author: Jan Schneider <jan@horde.org>
Date: Wed May 14 17:19:42 2014 +0200
[jan] Export VTIMEZONE components only once per TZID (
Bug #12988).framework/Icalendar/lib/Horde/Icalendar.php | 10 ++-
framework/Icalendar/package.xml | 4 +-
.../Icalendar/test/Horde/Icalendar/ExportTest.php | 105
++++++++++++++++++++
3 files changed, 116 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/d6fd510312c5ecb20eb760cfb3da93ea94cea6f1
Queue ⇒ Horde Framework Packages
Assigned to Jan Schneider
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Same timezone exported multiple times in iCal format/subscription
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ Yes
New Attachment: horde-ical-uniquetimezone.diff
State ⇒ Unconfirmed
times when getting a calendar using remote ICS URL and when it
contains TZID dates.
To reproduce simply create multiple events with timezone data (same
timezone) and use the ICS subscription URL to download the iCal file
(via the rpc.php file). The VTIMEZONE block appears as many times as
the number of events using a TZID.
Here is a proposed (maybe not correctly whitespace formatted) patch
that does the same kind of comparison than the SabreDAV code path
(Sabre/CalDAV/ICSExportPlugin.php), it simply check if there's already
a Timezone with the same TZID and then prevents the new component to
be added.
This fixes the problem at least for Outlook 2010 which keeps popping
warnings about multiple defined timezones in shared calendars.
It seems rather strange to me that there are 2 ICS export paths in the
code ; merging them somehow could avoid managing special behavior
multiple times (like ensuring timezone is exported only once per TZID).