Summary | IFRAME sizing regression |
Queue | IMP |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | Horde Developers (at) , slusarz (at) horde (dot) org |
Requester | jan (at) horde (dot) org |
Created | 02/18/2014 (4155 days ago) |
Due | |
Updated | 03/18/2014 (4127 days ago) |
Assigned | 02/18/2014 (4155 days ago) |
Resolved | 03/18/2014 (4127 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit c5743be34d4d9ef90b558c645cf09dd594850e51
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Mar 18 13:12:14 2014 -0600
Bug #12978: Fix resize behavior when images are not blockedimp/js/imp.js | 28 +++++++++++++++++-----------
1 files changed, 17 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/c5743be34d4d9ef90b558c645cf09dd594850e51
changed when the document has completely loaded? This would reduce
the flickering to messages that don't specify image sizes.
after each individual image is loaded.
The issue might be we need to add a delay to the callback to the
resize method after the image onload event is triggered, because it is
possible the onload is triggered before the image is inserted/sized in
the IFRAME DOM element.
correctly are HTML messages with images that don't specify sizes, so
that the body resizes while the images load. Going back to that
message later when all images are cached works perfectly. Any chance
to trigger another resize just in case the body size changed when the
document has completely loaded? This would reduce the flickering to
messages that don't specify image sizes.
State ⇒ Resolved
commit d50926e82b7e48557373963f0668a91f31e1c833
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Mar 18 00:11:02 2014 -0600
Bug #12978: More tweaking of IFRAME sizing algorithmimp/js/imp.js | 19 +++++++++++++------
1 files changed, 13 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/d50926e82b7e48557373963f0668a91f31e1c833
commit 718dc9394dc9639bf7093461ee2c0bb8f8e1c23c
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Mar 7 01:26:16 2014 -0700
Bug #12978: This seems to work at least slightly betterThe simple fact is that computed body height may not be the same
as computed
html tag height. Even stranger, the latter is oftentimes greater than
the former, even though it is embedded within the former.
imp/js/imp.js | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
http://git.horde.org/horde-git/-/commit/718dc9394dc9639bf7093461ee2c0bb8f8e1c23c
Assigned to
State ⇒ Feedback
3c713dd3a2e31c8a15517d1d50c2b8d6aad853ea break IFRAME sizing of
several HTML newsletters while I didn't experience any issues before
those patches. FF 27 Linux.
it breaks both dynamic and smartmobile views (it causes automatic
scrolling of the containing div, which breaks things like automatic
hiding of the addressbar in smartmobile, which is 100% unacceptable).
So these are not revertable
Not to mention that I have a 150 message mailbox of test messages that
at one point did not display correctly. The current code does as good
of a job as before, without breaking anything (no solution I've ever
come up with has displayed 100% of messages correctly).
If someone else wants to try and come up with a better solution, that
would be great. I've spent hours on this with minimal luck, and there
really is very little documentation I've found on the web that can
help. Two things need to be avoided:
1. Resizing based on defer/delay code
2. Height: auto
New Attachment: ALDI Newsletter - unsere Angebote ab Donnerstag_ 20. Februar.eml
New Attachment: Traum-Typen_ Kurzatmige Schwämme und Wiesen-Portfolios.eml
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Queue ⇒ IMP
Summary ⇒ IFRAME sizing regression
Type ⇒ Bug
3c713dd3a2e31c8a15517d1d50c2b8d6aad853ea break IFRAME sizing of
several HTML newsletters while I didn't experience any issues before
those patches. FF 27 Linux.