Tickets :: [#12869] ical import: RRULE UNTIL is strict when it should be nonstrict

6.0.0-beta1

7/4/25

Summary	ical import: RRULE UNTIL is strict when it should be nonstrict
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	horde (at) equaeghe (dot) nospammail (dot) net
Created	11/28/2013 (4236 days ago)
Due
Updated	12/17/2013 (4217 days ago)
Assigned
Resolved	12/06/2013 (4228 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/17/2013 02:54:14 PM	Git Commit	Comment #9	Reply to this comment
Changes have been made in Git (master): commit d0d1f2fd8f82e80d910e08f91aa9c100f08ab916 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Tue Dec 17 09:45:03 2013 -0500 Add missing fixture. .../Date/test/Horde/Date/fixtures/~~bug12869~~.ics \| 44 ++++++++++++++++++++ 1 files changed, 44 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/d0d1f2fd8f82e80d910e08f91aa9c100f08ab916

12/17/2013 11:17:56 AM	Git Commit	Comment #8	Reply to this comment
Changes have been made in Git (master): commit d106d333b659efb4840ec27eb8b5c87703da5f13 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:58:07 2013 -0500 Add new test for ~~Bug: 12869~~ framework/Date/test/Horde/Date/RecurrenceTest.php \| 30 +++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/d106d333b659efb4840ec27eb8b5c87703da5f13

12/17/2013 11:17:51 AM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (master): commit 2fec6b85ec06c9f3cb87633f8e356c89371d0c35 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:55:10 2013 -0500 ~~Bug: 12869~~ Fix importing RRULE UNTIL values when they contain date parts. We were already treating UNTIL as inclusive as well as comparing them by datetime (as opposed to date). The problem was we weren't importing the time portion of the UNTIL value if it was present. framework/Date/lib/Horde/Date/Recurrence.php \| 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) http://git.horde.org/horde-git/-/commit/2fec6b85ec06c9f3cb87633f8e356c89371d0c35

12/17/2013 09:43:49 AM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (master): commit 83893b47c48d19f4f32b33d95fdfb79818ef3d35 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:58:07 2013 -0500 Add new test for ~~Bug: 12869~~ framework/Date/test/Horde/Date/RecurrenceTest.php \| 30 +++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/83893b47c48d19f4f32b33d95fdfb79818ef3d35

12/17/2013 09:43:46 AM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (master): commit 79fea3a5bff3c856f933820e9c98cd3ae2c8c1ab Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:55:10 2013 -0500 ~~Bug: 12869~~ Fix importing RRULE UNTIL values when they contain date parts. We were already treating UNTIL as inclusive as well as comparing them by datetime (as opposed to date). The problem was we weren't importing the time portion of the UNTIL value if it was present. framework/Date/lib/Horde/Date/Recurrence.php \| 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) http://git.horde.org/horde-git/-/commit/79fea3a5bff3c856f933820e9c98cd3ae2c8c1ab

12/06/2013 07:00:20 PM	Michael Rubinsky	Comment #4 Version ⇒ Git master Queue ⇒ Horde Framework Packages	Reply to this comment
Problem was in Horde_Date, not Kronolith.

12/06/2013 07:00:02 PM	Michael Rubinsky	Assigned to Michael Rubinsky State ⇒ Resolved

12/06/2013 06:59:41 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit d106d333b659efb4840ec27eb8b5c87703da5f13 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:58:07 2013 -0500 Add new test for ~~Bug: 12869~~ framework/Date/test/Horde/Date/RecurrenceTest.php \| 30 +++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/d106d333b659efb4840ec27eb8b5c87703da5f13

12/06/2013 06:59:36 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit 2fec6b85ec06c9f3cb87633f8e356c89371d0c35 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Dec 6 13:55:10 2013 -0500 ~~Bug: 12869~~ Fix importing RRULE UNTIL values when they contain date parts. We were already treating UNTIL as inclusive as well as comparing them by datetime (as opposed to date). The problem was we weren't importing the time portion of the UNTIL value if it was present. framework/Date/lib/Horde/Date/Recurrence.php \| 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) http://git.horde.org/horde-git/-/commit/2fec6b85ec06c9f3cb87633f8e356c89371d0c35

11/28/2013 01:01:48 PM	horde (at) equaeghe (dot) nospammail (dot) net	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed New Attachment: test.ics Patch ⇒ No Milestone ⇒ Queue ⇒ Kronolith Summary ⇒ ical import: RRULE UNTIL is strict when it should be nonstrict Type ⇒ Bug	Reply to this comment
When importing an ical file with an RRULE that ends on the exact moment of the recurring event (specified using UNTIL), a recurrence should be generated for that event. With Kronolith 4.14, this is not the case. So, in brief: Kronolith interprets the UNTIL as a strict bound, whereas it should interpret it as a nonstrict bound. Attached is a Google Calendar-generated ical file for which the incorrect behavior manifests itself. (Mailing list thread: http://thread.gmane.org/gmane.comp.horde.kronolith/6482 )