6.0.0-beta1
7/9/25

[#12787] caching javascript breaks mobile/smartphone view
Summary caching javascript breaks mobile/smartphone view
Queue Horde Base
Queue Version 5.1.4
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester robert (at) gmx (dot) li
Created 10/23/2013 (4277 days ago)
Due
Updated 10/24/2013 (4276 days ago)
Assigned 10/23/2013 (4277 days ago)
Resolved 10/24/2013 (4276 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/24/2013 12:52:28 AM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (master):

commit a2f79253680444662ebb68fa0f6ee22741f30b3f
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Wed Oct 23 18:50:17 2013 -0600

     [mms] Fix issue from upstream jsmin.c that was breaking parsing 
of a keyword immediately followed by a regexp (Bug #12787).

  .../Horde/Text/Filter/JavascriptMinify/JsMin.php   |   28 +++++++++++++++++--
  framework/Text_Filter/package.xml                  |    4 +-
  .../test/Horde/Text/Filter/JsminTest.php           |   10 +++++++
  3 files changed, 37 insertions(+), 5 deletions(-)

http://git.horde.org/horde-git/-/commit/a2f79253680444662ebb68fa0f6ee22741f30b3f
10/24/2013 12:52:25 AM Michael Slusarz Comment #6
State ⇒ Resolved
Reply to this comment
Fixed in Horde_Text_Filter 2.1.5.
10/24/2013 12:12:56 AM Michael Slusarz Comment #5 Reply to this comment
Test case:

This is legal javascript:

function foo() { return/\//.test(a); }

But is being parsed by jsmin.c as:

function foo(){return/\


10/23/2013 11:56:30 PM Michael Slusarz Comment #4 Reply to this comment
Yes.  I've discovered this is actually a bug in Douglas Crockford's 
jsmin.c.  i.e. running jsmin.c from the command line chokes on the 
same code.  It might be this:

https://github.com/douglascrockford/JSMin/commit/0d58ea6e814edf309da8d22bb1f98ffbb16872ee#commitcomment-2905900
10/23/2013 11:22:26 PM Jan Schneider Comment #3
Assigned to Michael Slusarz
State ⇒ Assigned
Reply to this comment
The compressor compresses

                        isPath: function( url ) {
                                return ( /\// ).test( url );
                        },

from jquery mobile resp.

isPath:function(a){return/\//.test(a)}

from the minified version to

isPath:function(a){return/\}
10/23/2013 06:26:25 PM Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
Not confirmed.  Everything works fine for me.  I can verify that the 
browser is using the compressed CSS.

Clear out the static/ directory of old .css files.  The CSS for jquery 
mobile recently changed and, unfortunately, the Horde system won't 
automatically purge the cache of CSS contained in Horde_Core (as 
opposed to CSS contained in applications).
10/23/2013 09:23:05 AM robert (at) gmx (dot) li Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Base
Summary ⇒ caching javascript breaks mobile/smartphone view
Type ⇒ Bug
Reply to this comment
when caching javascript is enabled horde does not work right with 
mobile (smartphone) view.

From Mailing list:
"Seems like mobile view is missing all CSS."

Diabling caching  javascript fixes it.

Saved Queries