Summary | caching javascript breaks mobile/smartphone view |
Queue | Horde Base |
Queue Version | 5.1.4 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | robert (at) gmx (dot) li |
Created | 10/23/2013 (4277 days ago) |
Due | |
Updated | 10/24/2013 (4276 days ago) |
Assigned | 10/23/2013 (4277 days ago) |
Resolved | 10/24/2013 (4276 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit a2f79253680444662ebb68fa0f6ee22741f30b3f
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Oct 23 18:50:17 2013 -0600
[mms] Fix issue from upstream jsmin.c that was breaking parsing
of a keyword immediately followed by a regexp (
Bug #12787)..../Horde/Text/Filter/JavascriptMinify/JsMin.php | 28 +++++++++++++++++--
framework/Text_Filter/package.xml | 4 +-
.../test/Horde/Text/Filter/JsminTest.php | 10 +++++++
3 files changed, 37 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/a2f79253680444662ebb68fa0f6ee22741f30b3f
State ⇒ Resolved
This is legal javascript:
function foo() { return/\//.test(a); }
But is being parsed by jsmin.c as:
function foo(){return/\
jsmin.c. i.e. running jsmin.c from the command line chokes on the
same code. It might be this:
https://github.com/douglascrockford/JSMin/commit/0d58ea6e814edf309da8d22bb1f98ffbb16872ee#commitcomment-2905900
Assigned to Michael Slusarz
State ⇒ Assigned
isPath: function( url ) {
return ( /\// ).test( url );
},
from jquery mobile resp.
isPath:function(a){return/\//.test(a)}
from the minified version to
isPath:function(a){return/\}
State ⇒ Feedback
browser is using the compressed CSS.
Clear out the static/ directory of old .css files. The CSS for jquery
mobile recently changed and, unfortunately, the Horde system won't
automatically purge the cache of CSS contained in Horde_Core (as
opposed to CSS contained in applications).
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Base
Summary ⇒ caching javascript breaks mobile/smartphone view
Type ⇒ Bug
mobile (smartphone) view.
From Mailing list:
"Seems like mobile view is missing all CSS."
Diabling caching javascript fixes it.