6.0.0-beta1
7/7/25

[#12707] incrementLoopCounter makes cache_data grow
Summary incrementLoopCounter makes cache_data grow
Queue Synchronization
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester horde (at) albasoft (dot) com
Created 09/25/2013 (4303 days ago)
Due
Updated 09/27/2013 (4301 days ago)
Assigned 09/25/2013 (4303 days ago)
Resolved 09/27/2013 (4301 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
09/27/2013 02:17:54 PM Michael Rubinsky State ⇒ Resolved
 
09/27/2013 02:16:29 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 96483e0d91a027c338b703995e0b123b31684488
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Sep 27 10:15:05 2013 -0400

     Add migration to remove synckeycounter data.

     Removes data erroneously added due to Bug: 12707

  .../20_horde_activesync_removesynccounters.php     |   23 
++++++++++++++++++++
  1 files changed, 23 insertions(+), 0 deletions(-)

http://git.horde.org/horde-git/-/commit/96483e0d91a027c338b703995e0b123b31684488
09/27/2013 02:16:26 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (master):

commit 3bfbf250a347073a597b8aeeb3b81a0829834836
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Sep 27 09:52:28 2013 -0400

     We no longer use loop counters.

     Bug: 12707

  .../lib/Horde/ActiveSync/Collections.php           |   39 
--------------------
  .../lib/Horde/ActiveSync/Request/Sync.php          |    3 --
  2 files changed, 0 insertions(+), 42 deletions(-)

http://git.horde.org/horde-git/-/commit/3bfbf250a347073a597b8aeeb3b81a0829834836
09/25/2013 05:33:57 PM Michael Rubinsky Comment #2
Assigned to Michael Rubinsky
State ⇒ Assigned
Reply to this comment
My fault. I removed the functionality that checks the counters for 
syncloops for various reasons. I neglected to remove the code that 
increased the counters though.
09/25/2013 05:21:43 PM horde (at) albasoft (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ incrementLoopCounter makes cache_data grow
Queue ⇒ Synchronization
Milestone ⇒
Patch ⇒ Yes
New Attachment: hordewm5-activesync_clear_synckeycounter.patch Download
State ⇒ Unconfirmed
Reply to this comment
horde_activesync_cache.cahe_data  was growing too much for all my devices.
I realized that "synckeycounter" was to blame, and there was a synckey 
with a counter for every exchanged synckey and every collection.

Looking into code, "incrementLoopCounter" in 
Horde/ActiveSync/Collections.php was generating that data, but no 
function was checking or removing data from synckeycounter, so it just 
grows with every sync. I guess "checkLoopCounters" will do it in a 
future release.

Attached patch aims to be a way to clean a running database without 
having to do a whole clean and resync.
Commenting  "incrementLoopCounter"  in 
Horde/ActiveSync/Request/Sync.php will stop database growing but won't 
clean a running database.

Saved Queries