6.0.0-beta1
11/8/25

[#12671] Add negative regex match-type for ingo Sieve rules
Summary Add negative regex match-type for ingo Sieve rules
Queue Ingo
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester pete.beardmore (at) msn (dot) com
Created 09/11/2013 (4441 days ago)
Due
Updated 08/07/2014 (4111 days ago)
Assigned
Resolved 08/07/2014 (4111 days ago)
Milestone
Patch Yes

History
08/07/2014 11:11:10 PM Git Commit Comment #9 Reply to this comment
Changes have been made in Git (master):

commit 56d16169a9c37a425876d0ca3e4c47e601a19d16
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Aug 7 17:05:26 2014 -0600

     Simplify test - since it is essentially identical to the existing 
regex code

     Request #12671

  ingo/lib/Script/Sieve.php |   16 ++++------------
  1 files changed, 4 insertions(+), 12 deletions(-)

http://github.com/horde/horde/commit/56d16169a9c37a425876d0ca3e4c47e601a19d16
08/07/2014 11:11:08 PM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (master):

commit a4cde86a441511573e1bf5ef4bcb6f0a5bd02d54
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Aug 7 17:00:47 2014 -0600

     [mms] Add support for a negative regex test to the Sieve driver 
(Request #12671; Pete Beardmore <pete.beardmore@msn.com>).

     Conflicts:
             ingo/docs/CHANGES
             ingo/package.xml

  ingo/docs/CHANGES |    2 ++
  ingo/package.xml  |    1 +
  2 files changed, 3 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/a4cde86a441511573e1bf5ef4bcb6f0a5bd02d54
08/07/2014 11:11:06 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (master):

commit 86857f885a5e27cc73f24a3975b7bfd8c8518817
Author: Pete Beardmore <pete.beardmore@msn.com>
Date:   Wed Sep 11 19:35:19 2013 +0100

     add negative regex match-type for ingo sieve rules

     -Sieve regex rules are based on Posix which has no support for enhanced
     (Perl/Java) features such as lookarounds
     -negating a complex regexp as would be made possible by this patch is
     simpler than jumping through hoops by use of multiple rules
     -Ingo appears to support the 'not regex' case for other backends

     Request #12671

     Signed-off-by: Michael M Slusarz <slusarz@horde.org>

  ingo/config/fields.php    |    2 +-
  ingo/lib/Script/Sieve.php |   14 ++++++++++++++
  ingo/lib/Storage.php      |    3 ++-
  3 files changed, 17 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/86857f885a5e27cc73f24a3975b7bfd8c8518817
08/07/2014 11:10:46 PM Michael Slusarz Comment #6
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
Thanks.

Ingo 3.2.1
08/07/2014 11:10:36 PM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit f0c9dcae6ce436a0be133a6a1c6cd7a13741a719
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Aug 7 17:05:26 2014 -0600

     Simplify test - since it is essentially identical to the existing 
regex code

     Request #12671

  ingo/lib/Script/Sieve.php |   16 ++++------------
  1 files changed, 4 insertions(+), 12 deletions(-)

http://github.com/horde/horde/commit/f0c9dcae6ce436a0be133a6a1c6cd7a13741a719
08/07/2014 11:10:34 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 0a6e739f18a73af3d73553a516946b54f396486d
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Aug 7 17:00:47 2014 -0600

     [mms] Add support for a negative regex test to the Sieve driver 
(Request #12671; Pete Beardmore <pete.beardmore@msn.com>).

  ingo/docs/CHANGES |    2 ++
  ingo/package.xml  |    2 ++
  2 files changed, 4 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/0a6e739f18a73af3d73553a516946b54f396486d
08/07/2014 11:10:31 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 75e8e9442843d3335a33c6383744e2873cd88880
Author: Pete Beardmore <pete.beardmore@msn.com>
Date:   Wed Sep 11 19:35:19 2013 +0100

     add negative regex match-type for ingo sieve rules

     -Sieve regex rules are based on Posix which has no support for enhanced
     (Perl/Java) features such as lookarounds
     -negating a complex regexp as would be made possible by this patch is
     simpler than jumping through hoops by use of multiple rules
     -Ingo appears to support the 'not regex' case for other backends

     Request #12671

     Signed-off-by: Michael M Slusarz <slusarz@horde.org>

  ingo/config/fields.php    |    2 +-
  ingo/lib/Script/Sieve.php |   14 ++++++++++++++
  ingo/lib/Storage.php      |    3 ++-
  3 files changed, 17 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/75e8e9442843d3335a33c6383744e2873cd88880
08/02/2014 08:53:44 AM pete (dot) beardmore (at) msn (dot) com Comment #2
New Attachment: add.negative.regex.match.type.for.ingo.sieve.rules.diff Download
Reply to this comment
just checking on the status of this ..untouched.

added comment to the commit in the new attachment
09/11/2013 06:43:46 PM pete (dot) beardmore (at) msn (dot) com Comment #1
Milestone ⇒
State ⇒ New
New Attachment: 0001-Add-negative-regex-match-type-for-ingo-Sieve-rules.patch Download
Patch ⇒ Yes
Queue ⇒ Ingo
Summary ⇒ Add negative regex match-type for ingo Sieve rules
Type ⇒ Enhancement
Priority ⇒ 1. Low
Reply to this comment
sieve regex rules are based on Posix which has no support for enhanced 
(Perl / Java) features such as lookarounds.

negating a complex regexp via the attached seemed easier than trying 
to jump through hoops with multiple rules for me.

Ingo appears to support the 'not regex' case for other backends so..

Saved Queries