6.0.0-alpha12
6/12/25

[#12661] ansel & nginx & xsendfile patch
Summary ansel & nginx & xsendfile patch
Queue Ansel
Queue Version 3.0.0
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester sca (at) andreasschulze (dot) de
Created 09/07/2013 (4296 days ago)
Due
Updated 12/17/2013 (4195 days ago)
Assigned
Resolved 09/14/2013 (4289 days ago)
Milestone
Patch Yes

History
12/17/2013 11:38:03 AM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit 474068bd5de7b13343b624fe1eb9e3753a7bd8ce
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Sep 14 13:32:12 2013 -0400

     Add support for nginx sendfile headers.

     Bug: 12661

  ansel/img/download.php |    4 +---
  ansel/img/full.php     |    4 +---
  ansel/img/index.php    |    4 +---
  ansel/img/mini.php     |    4 +---
  ansel/img/screen.php   |    4 +---
  ansel/img/thumb.php    |    5 +----
  ansel/lib/Ansel.php    |   20 ++++++++++++++++++++
  7 files changed, 26 insertions(+), 19 deletions(-)

http://git.horde.org/horde-git/-/commit/474068bd5de7b13343b624fe1eb9e3753a7bd8ce
09/14/2013 05:34:16 PM Michael Rubinsky Comment #3
State ⇒ Resolved
Reply to this comment
Implemented in a slightly different way.

Ansel 3.0.1
09/14/2013 05:33:46 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 665e67cb528fb185d87d1349c5b9b1125f29b596
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Sat Sep 14 13:32:12 2013 -0400

     Add support for nginx sendfile headers.

     Bug: 12661

  ansel/img/download.php |    4 +---
  ansel/img/full.php     |    4 +---
  ansel/img/index.php    |    4 +---
  ansel/img/mini.php     |    4 +---
  ansel/img/screen.php   |    4 +---
  ansel/img/thumb.php    |    5 +----
  ansel/lib/Ansel.php    |   20 ++++++++++++++++++++
  7 files changed, 26 insertions(+), 19 deletions(-)

http://git.horde.org/horde-git/-/commit/665e67cb528fb185d87d1349c5b9b1125f29b596
09/07/2013 09:12:02 PM sca (at) andreasschulze (dot) de Comment #1
Priority ⇒ 1. Low
New Attachment: nginx-xsendfile.patch Download
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ansel
Summary ⇒ ansel & nginx & xsendfile patch
Type ⇒ Enhancement
State ⇒ New
Reply to this comment
Date: Sat, 07 Sep 2013
From: Andreas Schulze

Using ansel with nginx webserver and xsendfile feature is not implemented now.
So I wrote a little patch. It simply add the nginx specific header to 
the relevant places.

Now I could extend nginx.conf:

location /x-sendfile/ {
   internal;
   alias /;
}

That work for me. If others like the patch it should be extended to 
distinguish
lighttpd and nginx. I expect nginx or lighttp don't remove the header 
indended for the other server.
That will disclose file system location information. That may be unwanted.

Andreas

Date: Sat, 07 Sep 2013
From: Michael J Rubinsky

Please file an enhancement request on http://bugs.horde.org so this
doesn't get lost before I remember to look at it.

Saved Queries