| Summary | Horde_Alarm: Unify date formats / fix _list() for sqlite |
| Queue | Horde Framework Packages |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 08/28/2013 (4341 days ago) |
| Due | |
| Updated | 11/22/2013 (4255 days ago) |
| Assigned | |
| Resolved | 11/22/2013 (4255 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
State ⇒ Resolved
commit f4634fd16a13943ff47488b6216dc9718e99cef5
Author: Jan Schneider <jan@horde.org>
Date: Fri Nov 22 14:17:02 2013 +0100
Use constant and don't rely on correctly set default format (
Bug #12637).framework/Alarm/lib/Horde/Alarm/Sql.php | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/f4634fd16a13943ff47488b6216dc9718e99cef5
commit 44fd752925c9f8d2b0085ce8b2ffb53f3b6e7e48
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Aug 28 23:37:59 2013 +0200
Unify date formats
We insert dates as '2013-08-28 18:08:48' into the database
and later on query for them like '2013-08-28T18:08:48'.
This breaks for sqlite as it does not have
a designated 'datetime' type. It compares the date
as plain strings, which works for a unified date format only.
Bug 12637Signed-off-by: Jan Schneider <jan@horde.org>
framework/Alarm/lib/Horde/Alarm/Sql.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/44fd752925c9f8d2b0085ce8b2ffb53f3b6e7e48
New Attachment: 0001-Unify-date-formats.patch
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Horde_Alarm: Unify date formats / fix _list() for sqlite
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Horde_Alarm currently mixes ISO-8601 dates ('2013-08-28T18:08:48')
and dates formatted like this '2013-08-28 18:08:48'.
This breaks for sqlite since it does not have a designated datetime type,
it just compares datetime as strings[1].
[1] http://www.mail-archive.com/sqlite-users@sqlite.org/msg78962.html
Attached patch makes sure we stick to just one date format.
This fixes the horde-alarms script for me.
Cheers,
Thomas