6.0.0-beta1
7/5/25

[#12636] Core: Fix 'activesync_replyposition' pref readout
Summary Core: Fix 'activesync_replyposition' pref readout
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 08/28/2013 (4329 days ago)
Due
Updated 07/31/2014 (3992 days ago)
Assigned 08/28/2013 (4329 days ago)
Resolved 08/30/2013 (4327 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch Yes

History
07/31/2014 01:34:12 PM Michael Rubinsky Comment #6 Reply to this comment
Can you find out the bug number for me, don't find it here:
http://bugs.horde.org/queue/sync
Bug: 13355  - It was mistakenly kept in the framework queue. I've 
moved it to the synchronization queue.
Is there a solution for this issue in Horde 5.2 planned?
The "solution" was to remove the functionality in 5.2. I.e., you no 
longer have a choice as to where the reply text is placed when using 
ActiveSync. The solution we had in place was a hack, at best, to work 
around the fact that ActiveSync assumes replies will always be top 
posted. This led to all sorts of issues. See the other ticket for a 
more detailed explanation.
07/31/2014 10:50:47 AM samuel (dot) wolf (at) wolf-maschinenbau (dot) de Comment #5 Reply to this comment
There is a bug ticket regarding this, but don't have the ticket number handy.
Can you find out the bug number for me, don't find it here:
http://bugs.horde.org/queue/sync

Is there a solution for this issue in Horde 5.2 planned?
If yes, did you need a sponsoring?
07/30/2014 03:03:28 PM Michael Rubinsky Comment #4 Reply to this comment
There was a regression in that code, yes.

However, the functionality surrounding that pref has been removed for 
the next bugfix release for various reasons.

There is a bug ticket regarding this, but don't have the ticket number handy.
07/30/2014 02:37:49 PM samuel (dot) wolf (at) wolf-maschinenbau (dot) de Comment #3 Reply to this comment
Sorry for reopen this old bug report but I see this issue with Horde 
5.2.0 and Horde_ActiveSync 2.16.11 stable again(?)
08/30/2013 05:26:03 PM Michael Rubinsky State ⇒ Resolved
 
08/30/2013 05:25:44 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 3688d8c13448e002c04b80e8491cedb73366636b
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date:   Wed Aug 28 19:21:35 2013 +0200

     Fix 'activesync_replyposition' pref readout

     The moment we read out the 'activesync_replyposition'
     in the constructor was before the user is authenticated.

     Therefore the prefs backend will return the default value,
     which is 'bottom'. Setting the pref to 'top' via the UI never worked.

     Fix it by delaying the read out until the reply/forward action.
     Keep "reply_top" parameter handling as compatible as possible.

     Bug 12636

     Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  .../Core/lib/Horde/Core/ActiveSync/Driver.php      |   14 ++++++++------
  .../lib/Horde/Core/Factory/ActiveSyncBackend.php   |    3 +--
  2 files changed, 9 insertions(+), 8 deletions(-)

http://git.horde.org/horde-git/-/commit/3688d8c13448e002c04b80e8491cedb73366636b
08/28/2013 05:28:26 PM Thomas Jarosch Patch ⇒ Yes
State ⇒ Assigned
Assigned to Michael Rubinsky
New Attachment: 0001-Fix-activesync_replyposition-pref-readout.patch Download
 
08/28/2013 05:27:14 PM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Core: Fix 'activesync_replyposition' pref readout
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
The moment we read out the 'activesync_replyposition'
in the constructor was before the user is authenticated.

Therefore the prefs backend will return the default value,
which is 'bottom'. Setting the pref to 'top' via the UI never worked.

Fix it by delaying the read out until the reply/forward action.
Keep "reply_top" parameter handling as compatible as possible.

Saved Queries