Summary | Core: Fix 'activesync_replyposition' pref readout |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 08/28/2013 (4329 days ago) |
Due | |
Updated | 07/31/2014 (3992 days ago) |
Assigned | 08/28/2013 (4329 days ago) |
Resolved | 08/30/2013 (4327 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
http://bugs.horde.org/queue/sync
Bug: 13355- It was mistakenly kept in the framework queue. I'vemoved it to the synchronization queue.
longer have a choice as to where the reply text is placed when using
ActiveSync. The solution we had in place was a hack, at best, to work
around the fact that ActiveSync assumes replies will always be top
posted. This led to all sorts of issues. See the other ticket for a
more detailed explanation.
http://bugs.horde.org/queue/sync
Is there a solution for this issue in Horde 5.2 planned?
If yes, did you need a sponsoring?
However, the functionality surrounding that pref has been removed for
the next bugfix release for various reasons.
There is a bug ticket regarding this, but don't have the ticket number handy.
5.2.0 and Horde_ActiveSync 2.16.11 stable again(?)
commit 3688d8c13448e002c04b80e8491cedb73366636b
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Aug 28 19:21:35 2013 +0200
Fix 'activesync_replyposition' pref readout
The moment we read out the 'activesync_replyposition'
in the constructor was before the user is authenticated.
Therefore the prefs backend will return the default value,
which is 'bottom'. Setting the pref to 'top' via the UI never worked.
Fix it by delaying the read out until the reply/forward action.
Keep "reply_top" parameter handling as compatible as possible.
Bug 12636Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>
.../Core/lib/Horde/Core/ActiveSync/Driver.php | 14 ++++++++------
.../lib/Horde/Core/Factory/ActiveSyncBackend.php | 3 +--
2 files changed, 9 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/3688d8c13448e002c04b80e8491cedb73366636b
State ⇒ Assigned
Assigned to Michael Rubinsky
New Attachment: 0001-Fix-activesync_replyposition-pref-readout.patch
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Core: Fix 'activesync_replyposition' pref readout
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
in the constructor was before the user is authenticated.
Therefore the prefs backend will return the default value,
which is 'bottom'. Setting the pref to 'top' via the UI never worked.
Fix it by delaying the read out until the reply/forward action.
Keep "reply_top" parameter handling as compatible as possible.