6.0.0-beta1
7/17/25

[#12633] AS: Reset sync state on change of default share
Summary AS: Reset sync state on change of default share
Queue Synchronization
Queue Version Git master
Type Bug
State Not A Bug
Priority 1. Low
Owners
Requester thomas.jarosch (at) intra2net (dot) com
Created 08/28/2013 (4341 days ago)
Due
Updated 08/28/2013 (4341 days ago)
Assigned 08/28/2013 (4341 days ago)
Resolved 08/28/2013 (4341 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
08/28/2013 03:44:34 PM Thomas Jarosch Comment #3
State ⇒ Not A Bug
Reply to this comment
When the default pref is changed in Kronolith, the sync_calendars 
pref *is* reset, which should trigger the state to be reset. See the 
on_change property for the default_share pref. Same for Nag, from 
the looks of it.
Mea culpa, I had to read the code twice to finally understand how 
"$haveDefault" works.
Sorry for the noise.
08/28/2013 01:56:41 PM Michael Rubinsky Comment #2
State ⇒ Feedback
Reply to this comment
When the default pref is changed in Kronolith, the sync_calendars pref 
*is* reset, which should trigger the state to be reset. See the 
on_change property for the default_share pref. Same for Nag, from the 
looks of it.
08/28/2013 10:13:57 AM Thomas Jarosch Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Synchronization
Summary ⇒ AS: Reset sync state on change of default share
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
Hi,

while looking through prefs.php I noticed we reset the sync state on change
of f.e. 'sync_calendars' or 'sync_books'.

We don't reset the sync state when changing the default calendar share
or default tasklist. IMHO we should do this since the default share is 
synced to the device.


Ideally ActiveSync_State::removeState() could return a boolean if it 
removed something or not.
We should only notify the user if something got removed. Otherwise we confuse
users who don't use ActiveSync at all / never heard of it.

Note: All of this is of very low priority - more like a glitch ;)

Thomas

Saved Queries