6.0.0-RC7
6/23/26

[#12573] Tweak new window resize logic
Summary Tweak new window resize logic
Queue IMP
Queue Version Git master
Type Enhancement
State No Feedback
Priority 1. Low
Owners
Requester thomas.jarosch (at) intra2net (dot) com
Created 8/14/13 (4696 days ago)
Due
Updated 9/2/13 (4677 days ago)
Assigned
Resolved 9/2/13 (4677 days ago)
Milestone
Patch Yes

History
47 Michael Slusarz Comment #6
State ⇒ No Feedback
Reply to this comment
Will mark as "No Feedback" for now.
51 Thomas Jarosch Comment #5 Reply to this comment
I'll try to output some debug logging with alert() or console.log() tomorrow.
So much for that... anyway I'll probably won't have time for this 
before my vacation.
Feel free to close the ticket and I'll reopen it if ever needed in October.

510 Thomas Jarosch Comment #4 Reply to this comment
Ping?

As mentioned, 100 pixel offset is way too much.  So this needs to be 
worked around from a browser property value perspective if possible 
(i.e. detect browser that has broken window.availHeight.
I'll try to output some debug logging with alert() or console.log() tomorrow.
(I must admin I haven't done much Javascript development yet...)
to look at the actual values of my browser / window manager.

159 Michael Slusarz Comment #3 Reply to this comment
Ping?

As mentioned, 100 pixel offset is way too much.  So this needs to be 
worked around from a browser property value perspective if possible 
(i.e. detect browser that has broken window.availHeight.
19 Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
This isn't correct.

screen.availHeight is defined as the available screen height taking 
into account any OS-specific UI elements.  It works fine for me: on 
FF/Win 7 screen.availHeight is the height between the top of the 
screen and the bottom taskbar.

The 50 pixels are just in there because it is difficult to move the 
window if it takes up the full screen space.  But I'd rather not be 
throwing in random pixel offsets to account for broken browser behavior.
4011 Thomas Jarosch Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Tweak new window resize logic
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Adjust-compose-window-resize-logic.patch Download
State ⇒ New
Reply to this comment
Hi,

I really like the new window resize logic of imp.

On my desktop, the current code resizes the window so big
that the lower border of it directly sits on the taskbar.
That's makes grabbing the lower border harder than it needs to be.

I've changed the threshold value from -50 to -100 and now it looks nice.
That's also the same threshold value used in compose.js
(found while grepping for "- 100").

Cheers,
Thomas

Saved Queries