Summary | Search from top navigation broken with git HEAD |
Queue | IMP |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 08/14/2013 (4355 days ago) |
Due | |
Updated | 08/26/2013 (4343 days ago) |
Assigned | 08/16/2013 (4353 days ago) |
Resolved | 08/23/2013 (4346 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit 0ce9038b0cf2c21f0bc3c57079f57636f8d96de8
Author: Jan Schneider <jan@horde.org>
Date: Mon Aug 26 18:19:54 2013 +0200
Need a raw URL here too (
Bug #12572).so we have to deal with raw URLs even in HTML renderers. At least
until H6.
Horde_Tree_Renderer allows a Horde_Tree object to be specified in
the constructor... so create a class that extends Horde_Tree with
the fix, and then use this tree object explicitly with the topbar.
URLs in the initial topbar menu, which is handled fine by all browsers
AFAIK.
commit 0ce9038b0cf2c21f0bc3c57079f57636f8d96de8
Author: Jan Schneider <jan@horde.org>
Date: Mon Aug 26 18:19:54 2013 +0200
Need a raw URL here too (
Bug #12572).imp/lib/Application.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/0ce9038b0cf2c21f0bc3c57079f57636f8d96de8
have to deal with raw URLs even in HTML renderers. At least until H6.
Horde_Tree_Renderer allows a Horde_Tree object to be specified in the
constructor... so create a class that extends Horde_Tree with the fix,
and then use this tree object explicitly with the topbar.
link is broken after the dynamic update. "Search" works fine.
So I guess we need to do the same fix for "New message"
as we did for the "Search" link, at least for the dynamic topbar update.
workaround patch).
Once the dynamic AJAX topbar upate took place (how long does it
usually take?),
the link is still broken:
https://intradev/horde/imp/dynamic.php?Horde=ouaafb0e8qrtu7qcinfdbsqjk3&page=compose&popup=1
-> there's an "&" in there. Funnily the "New message" link works
on initial topbar creation, only "Search" was broken. After the
dynamic topbar update, both links don't work.
Assigned to Jan Schneider
Taken from Michael Slusarz
State ⇒ Resolved
Patch ⇒ No
for URI_SEARCH and URI_THREAD.
The other problem is that we unconditionally (and incorrectly) cast
all parameters to strings in Horde_Tree#addNodeParams(). The problem
is that for JS tree renderers, those need to be set to raw first, if
they are Horde_Url objects. That should happen only in the JS
renderer. But removing the string cast from Horde_Tree is a BC break,
so we have to deal with raw URLs even in HTML renderers. At least
until H6.
commit 25eb932a077ee4fb71bed04c6e87e063a2fac5a0
Author: Jan Schneider <jan@horde.org>
Date: Fri Aug 23 11:48:22 2013 +0200
Fix generating URLs for JavaScript (
Bug #12572).framework/Tree/lib/Horde/Tree.php | 1 +
imp/lib/Application.php | 4 ++--
imp/lib/Basic/Search.php | 4 +++-
imp/lib/Basic/Thread.php | 5 ++++-
imp/lib/Dynamic/Mailbox.php | 4 ++--
5 files changed, 12 insertions(+), 6 deletions(-)
http://git.horde.org/horde-git/-/commit/25eb932a077ee4fb71bed04c6e87e063a2fac5a0
State ⇒ Feedback
output time, not at generation time. You only want the raw, unencoded
URL in JavaScript, not in HTML output.
New Attachment: 0001-Fix-generating-the-search-URL.patch
Patch ⇒ Yes
Assigned to Michael Slusarz
folder context menu.
Firebug captured this URL:
https:/horde.server.com/horde/imp/basic.php?Horde=di96mh7fn06m37sghtmttnh0u1&%3Bpage=search&mailbox=SU5CT1g&token=tm0SvwXXXYnddcAO-UqFJg3
Note the & in there.
Jan told me it works for him on IRC. May be it's related to non-cookie
based sessions?
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Search from top navigation broken with git HEAD
Type ⇒ Bug
Queue ⇒ IMP
when I click on "Webmail -> Search" in the top navigation,
I get a "Page not found" backtrace with latest git HEAD.
IMP_Exception Object
(
[details] =>
[logged] => 1
[_logLevel:protected] => 0
[message:protected] => Page not found:
[string:Exception:private] =>
[code:protected] => 0
[file:protected] => /datastore/share/pear/www/horde/imp/basic.php
[line:protected] => 30
[trace:Exception:private] => Array
(
)
[previous:Exception:private] =>
)