| Summary | Kolab driver: Fix setting $this->_data twice. Unify duplicated code |
| Queue | Turba |
| Queue Version | Git master |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | jan (at) horde (dot) org |
| Requester | thomas.jarosch (at) intra2net (dot) com |
| Created | 07/31/2013 (4358 days ago) |
| Due | |
| Updated | 08/06/2013 (4352 days ago) |
| Assigned | |
| Resolved | 08/06/2013 (4352 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
State ⇒ Resolved
commit 1f1368f0cd2e5bd33b0af587348350a1250ad843
Author: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Wed Jul 31 17:34:37 2013 +0200
Kolab driver: Fix setting $this->_data twice. Unify duplicated code.
_getDataForAddressbook() was only used by _getData().
It was probably copied over from other Kolab drivers
which use a similar driver skeleton.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Jan Schneider <jan@horde.org>
Bug: 12518turba/lib/Driver/Kolab.php | 41 +++++++++++++++--------------------------
1 files changed, 15 insertions(+), 26 deletions(-)
http://git.horde.org/horde-git/-/commit/1f1368f0cd2e5bd33b0af587348350a1250ad843
Priority ⇒ 1. Low
New Attachment: 0001-Kolab-driver-Fix-setting-this-_data-twice.-Unify-dup.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Turba
Summary ⇒ Kolab driver: Fix setting $this->_data twice. Unify duplicated code
Type ⇒ Bug
State ⇒ Unconfirmed
attached patch fixes setting $this->_data twice in the Kolab driver.
It also makes the code path more clear to read by unifying
duplicated code hidden in another function.
Cheers,
Thomas