Summary | "Settings" over icon with Horde_Core-2.6.3 |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org |
Requester | samuel.wolf (at) wolf-maschinenbau (dot) de |
Created | 07/24/2013 (4374 days ago) |
Due | |
Updated | 08/06/2013 (4361 days ago) |
Assigned | 07/29/2013 (4369 days ago) |
Resolved | 08/06/2013 (4361 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit 7cc003c648eea4236aff3eafcc1f7aa42bf8f380
Author: Jan Schneider <jan@horde.org>
Date: Tue Aug 6 17:26:24 2013 +0200
[jan] Remove text overlaying menu icon (
Bug #12496).framework/Core/package.xml | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/7cc003c648eea4236aff3eafcc1f7aa42bf8f380
commit 062efef1af23eb8264814f52ef340fb893c2851a
Author: Jan Schneider <jan@horde.org>
Date: Tue Aug 6 17:24:40 2013 +0200
Don't set alternate text (
Bug #12496).Give up on supporting broken rendering engines of a browser
that's not supposed
to use this interface anway (
Bug #11937).framework/Core/lib/Horde/Core/Topbar.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/062efef1af23eb8264814f52ef340fb893c2851a
State ⇒ Assigned
There are definitely some concerns regarding making formatting changes
in a package that break the existing layout (as opposed to changes
that fix the current issue without breaking the existing layout).
and cleared my CSS cache and it was fixed.
stale CSS to clear. Could you link to the CSS change in github that
fixed this?
the github.com link from Michael Rubinsky below in this bug report. I
assume that may be the css change necessary. I did not have that css
in my screen.css (This is a default horde 5.1.2 install from pear). I
put it in (cleared any cached css) and it did not work. However,
copying the text-indent: -10000px; line from the selector
".horde-icon-settings a" to just ".horde-icon-settings" did fix the
issue. The "Settings" alternative text is no longer visible.
To be clear, here is what that part of my
horde/themes/default/screen.css looks like now:
.horde-icon-settings {
background-image: url("graphics/settings.png");
background-repeat: no-repeat;
text-indent: -10000px;
}
.horde-icon-settings:hover {
background-image: url("graphics/settings-active.png");
}
.horde-icon-settings a {
width: 22px;
height: 27px;
text-indent: -10000px;
}
and cleared my CSS cache and it was fixed.
stale CSS to clear. Could you link to the CSS change in github that
fixed this?
and cleared my CSS cache and it was fixed.
Horde version: git master
kind of fixes... since it is possible to run a version of Horde_Core
without requiring upgrading Horde (with the necessary CSS updates).
This is a limitation of the way we distribute our
applications/packages.
package I can update?
Horde, which contains the CSS changes.
http://bugs.horde.org/ticket/?searchfield=11937&x=0&y=0#c10
cleared my CSS cache and it was fixed.
His comment deals with some browsers where the gear icon will be
displayed and the text will appear AFTER the icon. If the text is
appearing UNDERNEATH the icon, the CSS is not updated.
Although this could get into a discussion of how to handle these kind
of fixes... since it is possible to run a version of Horde_Core
without requiring upgrading Horde (with the necessary CSS updates).
This is a limitation of the way we distribute our applications/packages.
Horde, which contains the CSS changes.
http://bugs.horde.org/ticket/?searchfield=11937&x=0&y=0#c10
New Attachment: settings_icon.png
State ⇒ Not A Bug
Horde, which contains the CSS changes.
State ⇒ Assigned
Assigned to Jan Schneider
https://github.com/horde/horde/commit/3bb702b55f2783084ad97a2a8e23e41337d07b59#framework/Core
State ⇒ Feedback
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ "Settings" over icon with Horde_Core-2.6.3
Type ⇒ Bug
Queue ⇒ Horde Framework Packages
Downgrade to Horde_Core 2.6.2 solve the problem.