Tickets :: [#12467] Calendar.php $_background should be checked with isset()

6.0.0-alpha12

6/12/25

Summary	Calendar.php $_background should be checked with isset()
Queue	Kronolith
Queue Version	4.1.2
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org
Requester	mm (at) freebsd (dot) org
Created	07/17/2013 (4348 days ago)
Due
Updated	07/17/2013 (4348 days ago)
Assigned
Resolved	07/17/2013 (4348 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

07/17/2013 10:31:03 AM	Jan Schneider	Assigned to Jan Schneider State ⇒ Resolved

07/17/2013 10:30:45 AM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit abc666f46143d251467b687bf0d6a9a2d22e20de Author: Jan Schneider <jan@horde.org> Date: Wed Jul 17 12:29:03 2013 +0200 Fix existance check (~~Bug #12467~~). kronolith/lib/Calendar.php \| 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/abc666f46143d251467b687bf0d6a9a2d22e20de

07/17/2013 07:03:22 AM	mm (at) freebsd (dot) org	Comment #2 New Attachment: Calendar.php.patch	Reply to this comment
Attaching patch again.

07/17/2013 07:02:24 AM	mm (at) freebsd (dot) org	Comment #1 Priority ⇒ 2. Medium Patch ⇒ Yes Milestone ⇒ Queue ⇒ Kronolith Summary ⇒ Calendar.php $_background should be checked with isset() Type ⇒ Bug State ⇒ Unconfirmed	Reply to this comment
Commit f6ccf3be789be1f276775e462ba78e0ce98e9e36 ($_background isn't always set) should check existence with isset(), PHP 5.4 otherwise reports errors: Jul 17 01:32:04 server horde: [kronolith] PHP ERROR: Undefined property: Kronolith_Calendar_Holiday::$_background [pid 50392 on line 62 of "/www/horde/kronolith/lib/Calendar.php"] Patch against head attached.