6.0.0-beta1
7/7/25

[#12420] tab not activated when selecting a saved filter
Summary tab not activated when selecting a saved filter
Queue Nag
Queue Version 4.1.0
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester x.van_dessel (at) ieee (dot) org
Created 06/28/2013 (4392 days ago)
Due
Updated 07/01/2013 (4389 days ago)
Assigned 07/01/2013 (4389 days ago)
Resolved 07/01/2013 (4389 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
07/01/2013 05:06:16 PM Git Commit Comment #7 Reply to this comment
Changes have been made in Git (master):

commit d23fd965976682c7d41c220137a0a0e106daeb63
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Mon Jul 1 13:04:23 2013 -0400

     Proper fix for Bug: 12420

  nag/lib/View/List.php |   14 +++++++-------
  1 files changed, 7 insertions(+), 7 deletions(-)

http://git.horde.org/horde-git/-/commit/d23fd965976682c7d41c220137a0a0e106daeb63
07/01/2013 05:06:15 PM Michael Rubinsky State ⇒ Resolved
 
07/01/2013 04:55:34 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (master):

commit 640723db2fa7f7f2692b28d7fa9ee809f9348862
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Mon Jul 1 12:54:59 2013 -0400

     Revert "Bug: 12420 Hightlight active smartlist tab."

     This reverts commit a68ef161f498f9e842ea1c9e82979e05315a55bf.

  nag/lib/View/List.php |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

http://git.horde.org/horde-git/-/commit/640723db2fa7f7f2692b28d7fa9ee809f9348862
07/01/2013 04:55:26 PM Michael Rubinsky Comment #5
State ⇒ Assigned
Reply to this comment
Not the correct fix.
07/01/2013 04:41:56 PM Michael Rubinsky State ⇒ Resolved
 
07/01/2013 04:37:37 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (master):

commit a68ef161f498f9e842ea1c9e82979e05315a55bf
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Mon Jul 1 12:36:45 2013 -0400

     Bug: 12420 Hightlight active smartlist tab.

  nag/lib/View/List.php |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

http://git.horde.org/horde-git/-/commit/a68ef161f498f9e842ea1c9e82979e05315a55bf
06/28/2013 05:03:12 PM x (dot) van_dessel (at) ieee (dot) org Comment #3 Reply to this comment
Just to clarify, the only issue you are reporting is that the tab 
for the saved search does appear activated while viewing it, right?
Correct.
06/28/2013 04:56:29 PM Michael Rubinsky Comment #2
Assigned to Michael Rubinsky
State ⇒ Assigned
Reply to this comment
Just to clarify, the only issue you are reporting is that the tab for 
the saved search does appear activated while viewing it, right?
06/28/2013 04:33:32 PM x (dot) van_dessel (at) ieee (dot) org Comment #1
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Nag
Summary ⇒ tab not activated when selecting a saved filter
Type ⇒ Bug
Priority ⇒ 1. Low
Reply to this comment
(The below example uses tags, but other criteria probably lead to 
similar results)
Define 2 tasks, both with tag TESTX
set one of the tasks to completed.
Select the view to show all unfinished tasks. You should at least see 
the unfinished TESTX task, and certainly not the completed one.
Define a filter which only selects on the TESTX tag (no other 
criteria), and save it as the TESTX filter.
It now appears as an additional tab, besides the "finished tasks" tab.
Reselect the unfinished tasks view. Its result should look OK.
Now select the TESTX tab, activating the stored filter query.
Only 2 tasks are shown now, the 2 tasks you created in the beginning. 
This is correct.
However, the TESTX tab is not highlighted. Instead, the last active 
tab (in this case the unfinished tasks) remains lighted. This clearly 
does not match the results that are shown, which show both finished 
and unfinished tasks.

Saved Queries